Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

configgrpc.go should support more encoding/compressions #2548

Closed
lizthegrey opened this issue Feb 24, 2021 · 1 comment · Fixed by #4088
Closed

configgrpc.go should support more encoding/compressions #2548

lizthegrey opened this issue Feb 24, 2021 · 1 comment · Fixed by #4088
Assignees
@hyunuk
Labels
enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest

Comments

@lizthegrey
Copy link
Member

Is your feature request related to a problem? Please describe.
Gzip is CPU intensive and offers less of a compression benefit than more modern compression like snappy or zstd

Describe the solution you'd like
https://github.com/mostynb/go-grpc-compression should be supported, not just gzip encoding, at

opentelemetry-collector/config/configgrpc/configgrpc.go

Line 45 in 68c5961

grpcCompressionKeyMap = map[string]string{

Describe alternatives you've considered
Do nothing, support gzip only
naseemkullah pushed a commit to naseemkullah/opentelemetry-collector that referenced this issue Mar 7, 2021
feat: make configgrpc support more encodings
79dfe12 
fixes open-telemetry#2548

add support for lz4, snappy and zstd by means of
https://github.com/mostynb/go-grpc-compression to configgrcpc.go's
grpc client compression setting

Signed-off-by: naseemkullah <naseem@transit.app>
@naseemkullah naseemkullah mentioned this issue Mar 7, 2021
Closed
@jrcamp jrcamp added enhancement New feature or request priority:p3 Lowest labels Mar 10, 2021
@pmm-sumo pmm-sumo mentioned this issue Mar 23, 2021
Closed
naseemkullah pushed a commit to naseemkullah/opentelemetry-collector that referenced this issue Mar 30, 2021
feat: make configgrpc support more encodings
152ff3a 
fixes open-telemetry#2548

add support for lz4, snappy and zstd by means of
https://github.com/mostynb/go-grpc-compression to configgrcpc.go's
grpc client compression setting

Signed-off-by: naseemkullah <naseem@transit.app>
@naseemkullah naseemkullah mentioned this issue Mar 30, 2021
Closed
naseemkullah pushed a commit to naseemkullah/opentelemetry-collector that referenced this issue Mar 30, 2021
feat: make configgrpc support more encodings
84bf7c1 
fixes open-telemetry#2548

add support for lz4, snappy and zstd by means of
https://github.com/mostynb/go-grpc-compression to configgrcpc.go's
grpc client compression setting

Signed-off-by: naseemkullah <naseem@transit.app>
@punya punya added the good first issue Good for newcomers label Jul 7, 2021
@hyunuk
Copy link
Contributor

hyunuk commented Sep 15, 2021

@alolita I can work on this issue!

@hyunuk hyunuk mentioned this issue Sep 16, 2021
Closed
6 tasks
@Ashmita152 Ashmita152 mentioned this issue Sep 20, 2021
Closed
@Aneurysm9 Aneurysm9 linked a pull request Sep 24, 2021 that will close this issue
feat: supports more compression methods for configgrpc #4088
Merged
@hyunuk hyunuk mentioned this issue Sep 24, 2021
Merged
@hyunuk hyunuk mentioned this issue Nov 2, 2021
Closed
@hyunuk hyunuk mentioned this issue Dec 5, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hyunuk hyunuk

Labels
enhancement New feature or request good first issue Good for newcomers priority:p3 Lowest
Projects
None yet
Milestone
No milestone
4 participants
@jrcamp @punya @lizthegrey @hyunuk