New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make configgrpc support more encodings #2849

Closed

naseemkullah wants to merge 2 commits into open-telemetry:main from naseemkullah:configgrpc-support-more-encodings

Member

naseemkullah commented Mar 30, 2021 •

edited

Loading

add support for lz4, snappy and zstd by means of
https://github.com/mostynb/go-grpc-compression to configgrcpc.go's
grpc client compression setting

fixes #2548

To test, I ran the docker-compose with a locally built image and configured the exporter with lz4 compression. No error was emitted:

...
exporters:
  otlp:
    endpoint: "otel-collector:4317"
    insecure: true
    compression: lz4
 ...

naseemkullah requested a review from a team

March 30, 2021 12:47


          feat: make configgrpc support more encodings

84bf7c1

fixes open-telemetry#2548

add support for lz4, snappy and zstd by means of
https://github.com/mostynb/go-grpc-compression to configgrcpc.go's
grpc client compression setting

Signed-off-by: naseemkullah <naseem@transit.app>

naseemkullah force-pushed the configgrpc-support-more-encodings branch from 152ff3a to 84bf7c1 Compare

March 30, 2021 12:50

naseemkullah mentioned this pull request

feat: make configgrpc support more encodings #2614

Closed

codecov bot commented Mar 30, 2021 •

edited

Loading

Codecov Report

Merging #2849 (f9eac38) into main (0738d68) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2849   +/-   ##
=======================================
  Coverage   91.78%   91.78%           
=======================================
  Files         291      291           
  Lines       15522    15522           
=======================================
  Hits        14247    14247           
  Misses        874      874           
  Partials      401      401

Impacted Files	Coverage Δ
config/configgrpc/configgrpc.go	`98.76% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0738d68...f9eac38. Read the comment docs.

bogdandrutu reviewed

View reviewed changes

config/configgrpc/README.md Outdated Show resolved Hide resolved

exporter/otlpexporter/cfg-schema.yaml Outdated Show resolved Hide resolved


          remove mention of default compression as there is none

f9eac38

Signed-off-by: naseemkullah <naseem@transit.app>

naseemkullah requested a review from bogdandrutu

March 31, 2021 00:46

Member Author

naseemkullah commented Apr 2, 2021

bump

Contributor

github-actions bot commented Apr 10, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Apr 20, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Apr 28, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

Member

tigrannajaryan commented Apr 29, 2021

@bogdandrutu @naseemkullah is this ready to be merged?

Member Author

naseemkullah commented Apr 29, 2021

yes @tigrannajaryan as far as I'm concerned

github-actions bot removed the Stale label

Contributor

github-actions bot commented May 8, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented May 22, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Jun 1, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Jun 15, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

Member

alolita commented Jun 15, 2021

@naseemkullah pl fix these conflicts and resubmit.

alolita added area:config and removed Stale labels

punya added the discussion-needed label

Contributor

github-actions bot commented Jun 26, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

bogdandrutu removed the Stale label

Contributor

github-actions bot commented Jul 6, 2021

This PR was marked stale due to lack of activity. It will be closed in 7 days.

github-actions bot added the Stale label

Member

punya commented Jul 7, 2021

@bogdandrutu can we close this out (or allow the stale bot to perform it's life mission)? From today's SIG meeting, we couldn't find anybody to take over ownership. People can always reopen when they are motivated to work on it.

github-actions bot removed the Stale label

jpkrohling closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:config discussion-needed