Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add factory and new-style config for Batch processor #52

Closed
tigrannajaryan opened this issue Jun 25, 2019 · 2 comments
Closed

Add factory and new-style config for Batch processor #52

tigrannajaryan opened this issue Jun 25, 2019 · 2 comments
Assignees
@tigrannajaryan
Milestone
0.1.0

Comments

@tigrannajaryan
Copy link
Member

See addattributesprocessor for example.
@tigrannajaryan tigrannajaryan self-assigned this Jun 25, 2019
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
84afd77 
This is part of remaining migration to new configuration format.

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
02925bb 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
6cc5b15 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
ffa30bd 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
04a6904 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
f682219 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
@tigrannajaryan tigrannajaryan mentioned this issue Jun 25, 2019
Merged
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
d929593 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
251dae3 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
tigrannajaryan pushed a commit to tigrannajaryan/opentelemetry-collector that referenced this issue Jun 25, 2019
Add factory and new-style config for Batch processor
fb146b9 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: open-telemetry#52

Testing done: make
pjanotti pushed a commit that referenced this issue Jun 25, 2019
@tigrannajaryan
Add factory and new-style config for Batch processor (#53)
5553892 
This is part of remaining migration to new configuration format.

- Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).

- Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).

Github issue: #52

Testing done: make
@tigrannajaryan
Copy link
Member Author

This is done.

@flands flands added this to the 0.1.0 milestone Jun 28, 2019
@MosheElisha
Copy link

Hello,

Can you please explain why all configuration examples contain both "batch" and "batch/2"?

processors:
  batch:
  batch/2:
    timeout: 10s
    send_batch_size: 10000
    send_batch_max_size: 11000

https://github.com/open-telemetry/opentelemetry-collector/blob/main/processor/batchprocessor/testdata/config.yaml

From what I understand, in the configuration above, you define two processors - one "batch" with default configuration and one "batch/2" with some configuration but in the "pipelines" you are only using "batch/2".

Should I define "batch" or "batch/2" or both? and why please.

Thanks.

hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jchengsfx
Update deb/rpm and installer script for fluentd (open-telemetry#52)
13087eb
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@rnburn @reyang
Add Lock-free Circular buffer (open-telemetry#52)
6a2b03e 
* Add AtomicUniquePtr

* Add CircularBuffer

* Add circular buffer benchmark

* Reformat

* Add cmake support

* Reformat

* Fix for gcc48

* Fix typos

* Fix misname

* Update sdk/src/common/circular_buffer.h

Co-Authored-By: Reiley Yang <reyang@microsoft.com>

* Reformat

* Fix cmake linkage

Co-authored-by: Reiley Yang <reyang@microsoft.com>
swiatekm pushed a commit to swiatekm/opentelemetry-collector that referenced this issue Oct 9, 2024
@Saber-W
Add OpenTelemetry Operator Helm chart to the existing Helm repo (open…
fcdfc70 
…-telemetry#52)

This commit implements OpenTelemetry Operator Helm chart, which allows users to install and manage the Operator in their Kubernetes cluster through Helm.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tigrannajaryan tigrannajaryan

Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

No branches or pull requests
3 participants
@flands @MosheElisha @tigrannajaryan