Add factory and new-style config for Batch processor #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrannajaryan
requested review from
bogdandrutu,
flands,
pjanotti and
songy23
as code owners
songy23
reviewed
Jun 25, 2019
| @@ -69,6 +69,7 @@ type Exporters map[string]Exporter | |||
| // Processor is the configuration of a processor. Specific processors must implement this | |||
| // interface and will typically embed ProcessorSettings struct or a struct that extends it. | |||
| type Processor interface { | |||
| NamedEntity | |||
There was a problem hiding this comment.
SetName() is called in internal/configv2/configv2.go. The name is used in internal/collector/processor/nodebatcher/factory.go
tigrannajaryan
force-pushed
the
feature/tigran/batch
branch
from
f682219
to
d929593
Compare
tigrannajaryan
force-pushed
the
feature/tigran/batch
branch
from
d929593
to
251dae3
Compare
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
=========================================
- Coverage 69.43% 69.3% -0.14%
=========================================
Files 85 85
Lines 5558 5567 +9
=========================================
- Hits 3859 3858 -1
- Misses 1480 1489 +9
- Partials 219 220 +1
Continue to review full report at Codecov.
|
This is part of remaining migration to new configuration format. - Added zap.Logger to ProcessorFactory functions because it is needed by this processor (and can be used if needed in other processors in the future). - Added Name/SetName to Processor interface because it is needed by this processor (this now also makes Processor uniform with Receiver and Exporter interfaces). Github issue: open-telemetry#52 Testing done: make
tigrannajaryan
force-pushed
the
feature/tigran/batch
branch
from
eb207ba
to
fb146b9
Compare
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this pull request
Jul 5, 2024
swiatekm
pushed a commit
to swiatekm/opentelemetry-collector
that referenced
this pull request
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of remaining migration to new configuration format.
Added zap.Logger to ProcessorFactory functions because it is
needed by this processor (and can be used if needed in other processors
in the future).
Added Name/SetName to Processor interface because it is
needed by this processor (this now also makes Processor uniform with
Receiver and Exporter interfaces).
Github issue: #52
Testing done: make