Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code coverage target #671

Closed
yurishkuro opened this issue Mar 20, 2020 · 2 comments · Fixed by #1355
Closed

Code coverage target #671

yurishkuro opened this issue Mar 20, 2020 · 2 comments · Fixed by #1355
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up

Comments

@yurishkuro
Copy link
Member

Since Jaeger is planning to start using otel collector, I wanted to check what code quality tooling is being used here. The code coverage is showing at 75%, which is much lower than Jaeger's target of 95% (*). Can it be raised and threshold checks added to CI?

(*): in Jaeger some small packages are explicitly excluded due to requiring external dependencies like storage or kafka.

cc @pavolloffay @objectiser
@yurishkuro yurishkuro mentioned this issue Mar 20, 2020
Closed
@bogdandrutu
Copy link
Member

@yurishkuro we should make this our top priority in April. Let's call April the coverage month :)

@bogdandrutu bogdandrutu mentioned this issue Mar 27, 2020
Merged
@bogdandrutu
Copy link
Member

bogdandrutu commented Mar 27, 2020 •
edited
Loading

I think the major difference was that you did calculate the coverage across packages which we did not, added #723 to fix that problem.

@yurishkuro suggest you use go-acc instead of manually written bash script to execute coverage across packages.

@yurishkuro yurishkuro mentioned this issue Mar 27, 2020
Closed
@tigrannajaryan tigrannajaryan added the help wanted Good issue for contributors to OpenTelemetry Service to pick up label May 13, 2020
@bogdandrutu bogdandrutu mentioned this issue May 20, 2020
Merged
@bogdandrutu bogdandrutu mentioned this issue Jul 14, 2020
Merged
MovieStoreGuy pushed a commit to atlassian-forks/opentelemetry-collector that referenced this issue Nov 11, 2021
@namreg
Add jaeger option that allows to specify custom http client (open-tel…
5863f85 
…emetry#671)
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this issue Apr 27, 2023
@jeffreyc-splunk
Update circleci jobs (open-telemetry#671)
a4511e6
Troels51 pushed a commit to Troels51/opentelemetry-collector that referenced this issue Jul 5, 2024
@eyjohn
Make Context::HasKey const (open-telemetry#671)
d129d42 
- Update `Context::HasKey` to be const
- Add const qualifier to HasKey,GetValue to validate constness
bogdandrutu pushed a commit that referenced this issue Sep 28, 2024
@jackgopack4 @andrzej-stencel @songy23
update cmd/builder documentation for docker image (#11234)
3de2590 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adding documentation for corresponding [PR #671 in
opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#671)

<!-- Issue number if applicable -->
#### Link to tracking issue
Closes #5712 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Github Actions and releases in personal fork,
github.com/jackgopack4/opentelemetry-collector-releases

<!--Describe the documentation added.-->
#### Documentation
updates to cmd/builder/README.md for OCB instructions and
docs/release.md for an automation that I also added in the releases PR
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
jackgopack4 added a commit to jackgopack4/opentelemetry-collector that referenced this issue Oct 8, 2024
@jackgopack4 @andrzej-stencel @songy23
update cmd/builder documentation for docker image (open-telemetry#11234)
6f596ce 
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description
Adding documentation for corresponding [PR open-telemetry#671 in
opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#671)

<!-- Issue number if applicable -->
#### Link to tracking issue
Closes open-telemetry#5712 

<!--Describe what testing was performed and which tests were added.-->
#### Testing
Github Actions and releases in personal fork,
github.com/jackgopack4/opentelemetry-collector-releases

<!--Describe the documentation added.-->
#### Documentation
updates to cmd/builder/README.md for OCB instructions and
docs/release.md for an automation that I also added in the releases PR
<!--Please delete paragraphs that you did not use before submitting.-->

---------

Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Good issue for contributors to OpenTelemetry Service to pick up
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update coverage requirement for the project to 90% bogdandrutu/opentelemetry-collector
3 participants
@bogdandrutu @yurishkuro @tigrannajaryan