-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update cmd/builder documentation for docker image #11234
Merged
bogdandrutu
merged 8 commits into
open-telemetry:main
from
jackgopack4:add-ocb-docker-documentation
Sep 28, 2024
Merged
update cmd/builder documentation for docker image #11234
bogdandrutu
merged 8 commits into
open-telemetry:main
from
jackgopack4:add-ocb-docker-documentation
Sep 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11234 +/- ##
==========================================
+ Coverage 91.44% 91.52% +0.08%
==========================================
Files 424 424
Lines 20182 20222 +40
==========================================
+ Hits 18456 18509 +53
+ Misses 1342 1329 -13
Partials 384 384 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co>
songy23
reviewed
Sep 25, 2024
update tag references in doc Co-authored-by: Yang Song <songy23@users.noreply.github.com>
songy23
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bogdandrutu
approved these changes
Sep 28, 2024
andrzej-stencel
added a commit
that referenced
this pull request
Oct 7, 2024
This reverts commit 3de2590.
mx-psi
pushed a commit
that referenced
this pull request
Oct 7, 2024
…ge" (#11379) Reverts #11234 The PR to publish container images for builder open-telemetry/opentelemetry-collector-releases#671 has not been merged yet (neither has the one adding "Update version" workflow open-telemetry/opentelemetry-collector-releases#684). We should only publish these docs after the images are published. Fixes #11347
jackgopack4
added a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding documentation for corresponding [PR open-telemetry#671 in opentelemetry-collector-releases](open-telemetry/opentelemetry-collector-releases#671) <!-- Issue number if applicable --> #### Link to tracking issue Closes open-telemetry#5712 <!--Describe what testing was performed and which tests were added.--> #### Testing Github Actions and releases in personal fork, github.com/jackgopack4/opentelemetry-collector-releases <!--Describe the documentation added.--> #### Documentation updates to cmd/builder/README.md for OCB instructions and docs/release.md for an automation that I also added in the releases PR <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Andrzej Stencel <andrzej.stencel@elastic.co> Co-authored-by: Yang Song <songy23@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding documentation for corresponding PR #671 in opentelemetry-collector-releases
Link to tracking issue
Closes #5712
Testing
Github Actions and releases in personal fork, github.com/jackgopack4/opentelemetry-collector-releases
Documentation
updates to cmd/builder/README.md for OCB instructions and docs/release.md for an automation that I also added in the releases PR