-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use obsreport.StartMetricsReceiveOp/EndMetricsReceiveOp
in host scrapers
#918
Milestone
Comments
To clarify:
|
Note no. 2 is not necessary as |
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this issue
Apr 27, 2023
…emetry#918) Bumps golang from 1.17.2-stretch to 1.17.3-stretch. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Troels51
pushed a commit
to Troels51/opentelemetry-collector
that referenced
this issue
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From @james-bebbington:
Had a bit of a deeper look at this. From what I understand, obsreport is a helper package for generating standard traces & metrics for collector components, and currently uses the OpenCensus libraries for this.
A couple of questions if I want to use this here:
I'm not sure what to provide for the "transport" attribute value (third parameter of StartMetricsReceiveOp). These metrics are scraped from the host rather than being "received" as such so it doesn't seem applicable - is it okay to pass an empty string?
obsreport.CountMetricPoints is only implemented for the OC proto format. It probably needs a second implementation for the in-memory data structure rather than doing a transformation manually before calling that function (should be relatively straightforward to add this, but probably better done in a separate PR)
The text was updated successfully, but these errors were encountered: