[chore][confmap] Add string representation to mocked env provider #10559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10559 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 393 393
Lines 18647 18647
=======================================
Hits 17218 17218
Misses 1069 1069
Partials 360 360 ☔ View full report in Codecov by Sentry. |
TylerHelmuth
approved these changes
Jul 8, 2024
codeboten
approved these changes
Jul 9, 2024
mx-psi
added a commit
that referenced
this pull request
Jul 12, 2024
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Makes type resolution strict and conforming to the behavior described in [the env vars RFC](https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/rfcs/env-vars.md) Depends on: - #10553 - #10555 - #10559 - open-telemetry/opentelemetry-collector-contrib/pull/33950 <!-- Issue number if applicable --> #### Link to tracking issue Fixes #9532, Fixes #8565 --------- Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds string representation to all inputs returned by mock env provider used in tests.
The real
envprovider (and all other providers on this repository) do this by default since they useNewRetrievedFromYAML.Note that certain types are not really obtainable with the real
envprovider (e.g.int32orfloat64). I have kept them and added the string representation manually.Link to tracking issue
Needed for #10554