Authentication processor 4/4 - Add configauth to configgrpc #1810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
requested review from
bogdandrutu,
dmitryax,
james-bebbington,
nilebox,
owais,
pjanotti and
tigrannajaryan
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1810 +/- ##
=======================================
Coverage 91.28% 91.28%
=======================================
Files 277 278 +1
Lines 16489 16503 +14
=======================================
+ Hits 15052 15065 +13
- Misses 1006 1007 +1
Partials 431 431
Continue to review full report at Codecov.
|
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-4
branch
from
c1081a6
to
0c61c84
Compare
|
@jpkrohling thank you for splitting into smaller PRs. |
|
Please rebase |
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-4
branch
from
0c61c84
to
e893ac4
Compare
|
Rebased and re-tested, confirming that it still works :-) |
bogdandrutu
reviewed
Sep 29, 2020
bogdandrutu
approved these changes
Sep 30, 2020
|
@jpkrohling can you make codecov happy? 👍 |
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-4
branch
from
5c2247d
to
166158a
Compare
Signed-off-by: Juraci Paixão Kröhling <juraci@kroehling.de>
jpkrohling
force-pushed
the
jpkrohling/authentication-processor-part-4
branch
from
166158a
to
4b43268
Compare
|
PR updated: new test, rebased and squashed. |
bogdandrutu
approved these changes
Oct 1, 2020
MovieStoreGuy
pushed a commit
to atlassian-forks/opentelemetry-collector
that referenced
this pull request
Nov 11, 2021
) * Removed different types of Detectors for Resources. This change simplifies different types of collectors into one list. The order of this list determines how they are applied. Defaults are applied when the user does not supply any detectors. To achieve default behavior and additional behavior a DefaultDetectors struct has been created * missed prometheus test. * Changed behavior around WithDetectors(nil) Added examples of use of WithDetectors. * Added NoOp example * Changed test to reflect acutal default case This changes because WithDetector() no longer is the same as not using WithDetector() * Unexports the noOp detector * Updated changelog * Fixes to spelling mistakes. * Added NewEmptyResouce and unexported builtin detectors * Fix for prometheus example * Resource has two Rs I need to get a new R key it seems. Co-authored-by: Sam Xie <xsambundy@gmail.com> * Replaced NewEmptyResource() with New() * Fix test function name * Comment fixups. * Apply suggestions from code review Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Co-authored-by: Sam Xie <xsambundy@gmail.com> Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
…y#1810) Bumps [boto3](https://github.com/boto/boto3) from 1.24.37 to 1.24.38. - [Release notes](https://github.com/boto/boto3/releases) - [Changelog](https://github.com/boto/boto3/blob/develop/CHANGELOG.rst) - [Commits](boto/boto3@1.24.37...1.24.38) --- updated-dependencies: - dependency-name: boto3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Added the configauth to configgrpc. Split from #1728.
This PR is based on top of #1809.
Link to tracking Issue: Part of the solution for #1424.
Testing: manual and unit tests.
Documentation: none.
Signed-off-by: Juraci Paixão Kröhling juraci@kroehling.de