Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve original error messages in OTLP exporter #2459

Merged
merged 1 commit into from
Feb 13, 2021

Conversation

mwear
Copy link
Member

@mwear mwear commented Feb 11, 2021

Description:
I was troubleshooting an issue where un-retryable exports were being retried. #2455 fixes the root cause and this PR improves error messages from the OTLP exporter. The exporter returns the same permanent error instance for each export which masks the underlying error and makes failures hard to debug. This PR preserves the original error by wrapping it in a permament error and returning it.

Previously all log message looked as follows:

failed to push metrics data via OTLP exporter: Permanent error: fatal error sending to server

Now they preserve the original error message:

failed to push metrics data via OTLP exporter: Permanent error: rpc error: code = InvalidArgument desc = [otlp: empty data point]

@mwear mwear requested a review from a team February 11, 2021 00:06
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #2459 (7618645) into main (9de6dd7) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2459   +/-   ##
=======================================
  Coverage   91.76%   91.76%           
=======================================
  Files         265      265           
  Lines       15111    15111           
=======================================
  Hits        13867    13867           
  Misses        866      866           
  Partials      378      378           
Impacted Files Coverage Δ
exporter/otlpexporter/otlp.go 71.79% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9de6dd7...7618645. Read the comment docs.

@bogdandrutu bogdandrutu merged commit e302ed1 into open-telemetry:main Feb 13, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
hughesjj pushed a commit to hughesjj/opentelemetry-collector that referenced this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants