-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preserve original error messages in OTLP exporter #2459
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2459 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 265 265
Lines 15111 15111
=======================================
Hits 13867 13867
Misses 866 866
Partials 378 378
Continue to review full report at Codecov.
|
jpkrohling
approved these changes
Feb 11, 2021
codeboten
approved these changes
Feb 11, 2021
carlosalberto
approved these changes
Feb 11, 2021
bogdandrutu
approved these changes
Feb 12, 2021
This was referenced Mar 8, 2021
Bump go.opentelemetry.io/collector from 0.17.0 to 0.22.0
MrAlias/opentelemetry-collector-contrib#915
Closed
This was referenced Mar 15, 2021
hughesjj
pushed a commit
to hughesjj/opentelemetry-collector
that referenced
this pull request
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I was troubleshooting an issue where un-retryable exports were being retried. #2455 fixes the root cause and this PR improves error messages from the OTLP exporter. The exporter returns the same permanent error instance for each export which masks the underlying error and makes failures hard to debug. This PR preserves the original error by wrapping it in a permament error and returning it.
Previously all log message looked as follows:
Now they preserve the original error message: