Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve original error messages in OTLP exporter #2459

Merged
merged 1 commit into from
Feb 13, 2021
Merged

Preserve original error messages in OTLP exporter #2459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions exporter/otlpexporter/otlp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ type exporterImp struct {
w *grpcSender
}

var (
errPermanentError = consumererror.Permanent(errors.New("fatal error sending to server"))
)

// Crete new exporter and start it. The exporter will begin connecting but
// this function may return before the connection is established.
func newExporter(cfg configmodels.Exporter) (*exporterImp, error) {
Expand Down Expand Up @@ -184,7 +180,7 @@ func processError(err error) error {

if !shouldRetry(st.Code()) {
// It is not a retryable error, we should not retry.
return errPermanentError
return consumererror.Permanent(err)
}

// Need to retry.
Expand Down