Change call pattern for scraper #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
@Aneurysm9 @dashpole can you please review? |
Aneurysm9
approved these changes
Jun 7, 2021
dashpole
approved these changes
Jun 7, 2021
alolita
added
the
ready-to-merge
|
@bogdandrutu this PR is ready to be merged. |
|
Please resolve the conflict. |
tigrannajaryan
approved these changes
Jun 16, 2021
|
@humivo can you please resolve this conflict so that this PR can be merged? |
|
@bogdandrutu @tigrannajaryan can you please merge? So that the related issue can be closed. Ty! |
alolita
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Change obsreport helpers for scraper to use the same pattern as Processor/Exporter and modified existences in the code.
Link to tracking Issue: Issue #3313