[chore] migrate receiver/* to use errors.Join #8225
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
mx-psi
reviewed
Aug 14, 2023
codeboten
reviewed
Aug 14, 2023
There was a problem hiding this comment.
Is there a way to override how errors.Join outputs the errors? Looking at https://github.com/open-telemetry/opentelemetry-collector/actions/runs/5852149629/job/15867545790?pr=8225#step:6:243, it looks like the output will be changed:
--- FAIL: TestScrapeErrorsCombine (0.00s)
scrapeerror_test.go:95:
Error Trace: /home/runner/work/opentelemetry-collector/opentelemetry-collector/receiver/scrapererror/scrapeerror_test.go:95
Error: Error message not equal:
expected: "bad scrapes; err: bad scrape"
actual : "bad scrapes\nerr: bad scrape"
Test: TestScrapeErrorsCombine
scrapeerror_test.go:95:
Error Trace: /home/runner/work/opentelemetry-collector/opentelemetry-collector/receiver/scrapererror/scrapeerror_test.go:95
Error: Error message not equal:
expected: "bad regular; err: bad reg"
actual : "bad regular\nerr: bad reg"
Test: TestScrapeErrorsCombine
scrapeerror_test.go:95:
Error Trace: /home/runner/work/opentelemetry-collector/opentelemetry-collector/receiver/scrapererror/scrapeerror_test.go:95
Error: Error message not equal:
expected: "bad two scrapes; 10 scrapes failed: bad things happened; bad event; event: something happened"
actual : "bad two scrapes\n10 scrapes failed: bad things happened\nbad event\nevent: something happened"
Test: TestScrapeErrorsCombine
FAIL
|
|
shivanshuraj1333
force-pushed
the
chore/issues/8210
branch
from
bc66e43
to
e481279
Compare
mx-psi
reviewed
Sep 1, 2023
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: #8210