Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid nil queue in queue_sender, consolidate implementation #8862

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Avoid nil queue in queue_sender, consolidate implementation #8862

merged 1 commit into from
Nov 13, 2023

Conversation

bogdandrutu
Copy link
Member

@bogdandrutu bogdandrutu commented Nov 13, 2023 •
edited
Loading

Also, fixes WithRetry called with a config that is disabled.

@bogdandrutu bogdandrutu requested review from a team and codeboten November 13, 2023 05:35
@bogdandrutu bogdandrutu force-pushed the noqueuenil branch 2 times, most recently from 01c36e8 to 36113f8 Compare November 13, 2023 05:38
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2023 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
exporter/exporterhelper/common.go 97.32% <100.00%> (+0.15%) ⬆️
exporter/exporterhelper/queue_sender.go 95.74% <100.00%> (-0.18%) ⬇️
exporter/exporterhelper/retry_sender.go 97.11% <80.00%> (-0.19%) ⬇️

📢 Thoughts on this report? Let us know!

@bogdandrutu
Avoid nil queue in queue_sender, consolidate implementation
05d783c 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
@dmitryax dmitryax added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 13, 2023
@bogdandrutu bogdandrutu merged commit 8e0f682 into open-telemetry:main Nov 13, 2023
34 of 35 checks passed
@bogdandrutu bogdandrutu deleted the noqueuenil branch November 13, 2023 17:59
@github-actions github-actions bot added this to the next release milestone Nov 13, 2023
@bryan-aguilar bryan-aguilar mentioned this pull request Jan 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitryax dmitryax dmitryax approved these changes

@codeboten codeboten Awaiting requested review from codeboten

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
v0.89.0
Development

Successfully merging this pull request may close these issues.
2 participants
@bogdandrutu @dmitryax