Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[exporterhelper] Log errors even if retry is not used #9270

Closed
wants to merge 4 commits into from

Conversation

bryan-aguilar
Copy link
Contributor

Description: Fixes regression of #8792. Test was changed in #8862 to use WithRetry() which removed the assertion that an error is still logged.

Link to tracking Issue: #9219

Please delete paragraphs that you did not use before submitting.

@bryan-aguilar bryan-aguilar requested review from a team and Aneurysm9 January 12, 2024 01:05
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a9aed14) 90.72% compared to head (9ea3a12) 90.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9270   +/-   ##
=======================================
  Coverage   90.72%   90.72%           
=======================================
  Files         341      341           
  Lines       18346    18347    +1     
=======================================
+ Hits        16645    16646    +1     
  Misses       1364     1364           
  Partials      337      337           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmitryax
Copy link
Member

It'll result in double reporting non-permanent because of this. The error reporting is in a messy state right now, I was planning to make it better. Let me think though this a bit

@bryan-aguilar
Copy link
Contributor Author

Closing in favor of #9282

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants