[exporterhelper] Log errors even if retry is not used #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9270 +/- ##
=======================================
Coverage 90.72% 90.72%
=======================================
Files 341 341
Lines 18346 18347 +1
=======================================
+ Hits 16645 16646 +1
Misses 1364 1364
Partials 337 337 ☔ View full report in Codecov by Sentry. |
|
It'll result in double reporting non-permanent because of this. The error reporting is in a messy state right now, I was planning to make it better. Let me think though this a bit |
|
Closing in favor of #9282 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes regression of #8792. Test was changed in #8862 to use
WithRetry()which removed the assertion that an error is still logged.Link to tracking Issue: #9219
Please delete paragraphs that you did not use before submitting.