Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Benchmark] Test BM_SpanCreation() and BM_NoopSpanCreation() are misleading, sampler is ignored #1612

Closed
marcalff opened this issue Sep 13, 2022 · 0 comments · Fixed by #1622
Closed

[Benchmark] Test BM_SpanCreation() and BM_NoopSpanCreation() are misleading, sampler is ignored #1612

marcalff opened this issue Sep 13, 2022 · 0 comments · Fixed by #1622
Labels
bug Something isn't working

Comments

@marcalff
Copy link
Member

In file:

sdk/test/trace/sampler_benchmark.cc

tests BM_SpanCreation() and BM_NoopSpanCreation() are identical.

This is because helper BenchmarkSpanCreation() ignores the sampler parameter passed.

Fix: use the sampler, so that the tests measure what is intended.
@marcalff marcalff added the bug Something isn't working label Sep 13, 2022
marcalff added a commit to marcalff/opentelemetry-cpp that referenced this issue Sep 20, 2022
@marcalff
Fixes issue open-telemetry#1612.
7400349
@marcalff marcalff mentioned this issue Sep 20, 2022
Merged
3 tasks
lalitb pushed a commit that referenced this issue Sep 21, 2022
@marcalff
Fixes issue #1612. (#1622)
909c26d
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this issue Dec 5, 2022
@marcalff @yxue
Fixes issue open-telemetry#1612. (open-telemetry#1622)
a95ee52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes span creation benchmark issue #1612. marcalff/opentelemetry-cpp
1 participant
@marcalff