Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes span creation benchmark issue #1612. #1622

Merged
merged 2 commits into from
Sep 21, 2022

Conversation

marcalff
Copy link
Member

Fixes #1612

Changes

The sampler parameter was ignored in benchmark span creation test.

Now BM_NoopSpanCreation() uses the always off sampler, measuring the Noop creation code.

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team September 20, 2022 19:39
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Merging #1622 (a6dd380) into main (85b7878) will decrease coverage by 0.07%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1622      +/-   ##
==========================================
- Coverage   85.12%   85.06%   -0.06%     
==========================================
  Files         159      159              
  Lines        4999     4999              
==========================================
- Hits         4255     4252       -3     
- Misses        744      747       +3     
Impacted Files Coverage Δ
ext/src/http/client/curl/http_client_curl.cc 80.31% <0.00%> (-1.13%) ⬇️

Copy link
Member

@esigo esigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT
Thanks for the fix :)

Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lalitb lalitb merged commit 909c26d into open-telemetry:main Sep 21, 2022
yxue pushed a commit to yxue/opentelemetry-cpp that referenced this pull request Dec 5, 2022
@marcalff marcalff deleted the fix_benchmark_span_1612 branch July 4, 2023 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Benchmark] Test BM_SpanCreation() and BM_NoopSpanCreation() are misleading, sampler is ignored
4 participants