fix: otlp http exporter block thread (#1141) #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
owent
reviewed
Dec 23, 2021
| @@ -233,6 +254,9 @@ class ResponseHandler : public http_client::EventHandler | |||
| std::condition_variable cv_; | |||
| std::mutex mutex_; | |||
|
|
|||
| // Whether notify has been called | |||
| bool stop_waiting_ = false; | |||
|
|
|||
| // Whether the response from Elasticsearch has been received | |||
There was a problem hiding this comment.
Could you please also fix the error message in this comment?
|
LGTM |
Codecov Report
@@ Coverage Diff @@
## main #1163 +/- ##
=======================================
Coverage 93.38% 93.38%
=======================================
Files 165 165
Lines 6233 6233
=======================================
Hits 5820 5820
Misses 413 413 |
wxl374
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141
Changes
fix deadlock when notify_all() called before wait().