Fix deadlock for ES #1169
Closed
Fix deadlock for ES #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1169 +/- ##
=======================================
Coverage 92.37% 92.37%
=======================================
Files 202 202
Lines 7336 7336
=======================================
Hits 6776 6776
Misses 560 560 |
ThomsonTan
reviewed
Jan 12, 2022
| @@ -100,6 +120,9 @@ class ResponseHandler : public http_client::EventHandler | |||
| std::condition_variable cv_; | |||
| std::mutex mutex_; | |||
|
|
|||
| // Whether notify has been called | |||
| bool stop_waiting_ = false; | |||
There was a problem hiding this comment.
Does this need to be atomic as it could be read/set from multiple threads?
There was a problem hiding this comment.
I think stop_waiting_ is already protected by mutex_, there's no need to declare stop_waiting_ as atomic.
esigo
reviewed
Jan 12, 2022
| switch (state) | ||
| { | ||
| case http_client::SessionState::CreateFailed: | ||
| case http_client::SessionState::ConnectFailed: |
There was a problem hiding this comment.
Would it be possible to add the enumeration values which are not handled?
enumeration value 'CreateFailed' not handled in switch [-Wswitch]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1141
Changes
Elastic search exporter also suffers from deadlock issue similar to otlp, fix similar to #1163
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes