ETW Exporter - Add support for Sampler and ID Generator #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1547 +/- ##
==========================================
- Coverage 85.02% 85.00% -0.02%
==========================================
Files 156 156
Lines 4977 4977
==========================================
- Hits 4231 4230 -1
- Misses 746 747 +1
|
lalitb
changed the title
lalitb
changed the title
lalitb
changed the title
lalitb
commented
Aug 10, 2022
| Tracer(*this, name, evtFmt)}; | ||
| return nostd::shared_ptr<opentelemetry::trace::Tracer>{tracer}; |
There was a problem hiding this comment.
@ThomsonTan - Can you please review this PR when you have time? The changes were crashing earlier while creating Spans that are not sampled. The fix is to create the Tracer using std::shared_ptr, and then move/encapsulate it to nostd::shared_ptr (as done in line 1014 and 1016 above).
3 tasks
ThomsonTan
reviewed
Aug 16, 2022
| @@ -26,18 +26,21 @@ | |||
|
|
|||
| #include "opentelemetry/common/key_value_iterable_view.h" | |||
|
|
|||
| #include "opentelemetry/trace/span.h" | |||
| #include "opentelemetry/trace/noop.h" | |||
| //#include "opentelemetry/trace/span.h" | |||
There was a problem hiding this comment.
Not required. Removed now.
ThomsonTan
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ETW exporter has its own header-only SDK which doesn't support Sampling, and custom id generation. This PR adds that support.
Please provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes