Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context helper functions #225

Merged
merged 47 commits into from
Jul 29, 2020
Merged

Context helper functions #225

merged 47 commits into from
Jul 29, 2020

Conversation

satac2
Copy link
Contributor

@satac2 satac2 commented Jul 28, 2020

Adds a static SetValue and GetValue to the RuntimeContext.

satac2 and others added 30 commits July 6, 2020 19:35
@satac2
added context header with dummy methods
4128a69
@satac2
Build and CMake files
cba6d5f
@satac2
auto formatted
b2e876e
@satac2
changed variable name from attributes to values
a7480c8
@satac2 @reyang
Update api/include/opentelemetry/context/context.h
96cd32f 
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@satac2
changed to follow the spec and added context_value type
5f0634b
@satac2
Merge branch 'context_api_dummy_methods' of github.com:satac2/opentel…
5d77daf 
…emetry-cpp into context_api_dummy_methods
@satac2
removed tests for this PR
68a1a70
@satac2
removed line
5e68574
@satac2
removed unnecessary include
16a492e
@satac2
changed a function to pass by reference
497eb67
@satac2
formatted
479dead
@satac2
Added tests.
2a78c48
@satac2
avoiding ABI compatibility issues
f51748f
@maxgolov
Merge branch 'master' into context_api_dummy_methods
7d73219
@satac2
added throw capture
3f85aa5
@satac2
Merge branch 'context_api_dummy_methods' of github.com:satac2/opentel…
0ec83e8 
…emetry-cpp into context_api_dummy_methods
@satac2
minor exception syntax error
21ea872
@satac2
Merge pull request #13 from satac2/context_api_dummy_methods
f016689 
Context api actual methods
@satac2
added runtime and threadlocal contexts
1f5e5fd
@satac2
add comparison operator to context api
bbf9559
@satac2
added stack for local storage of context objects
c8b7ed6
@satac2
removed old context.h
8d8b91f
@satac2
changed runtime context interface to match
4b78ac8
@satac2
Merge remote-tracking branch 'origin/master' into runtime_and_threadl…
d3cea59 
…ocal_context
@satac2
Merge remote-tracking branch 'origin/master' into runtime_and_threadl…
25bec5e 
…ocal_context
@satac2
formatted and added some size checks to prevent seg faults, also adde…
d77e445 
…d an overloaded comparison to context API
@satac2
added tests
0583e3c
@satac2
add a context_config file to choose which implementation the runtime …
e02fadb 
…context will use
@satac2
readding string_view_test
c06edc5
satac2 and others added 16 commits July 23, 2020 19:30
@satac2
threadlocalcontext is once again a derived class of RuntimeContext an…
fc42d91 
…d ContextConfig has been removed
@satac2
protected virtual members
ce78585
@satac2
reset string_view_test
02dbbdf
@reyang
Merge branch 'master' into runtime_and_threadlocal_context
c1ebc16
@satac2
added destructor that detaches the context to the Token
5a5df6e
@satac2
Merge branch 'runtime_and_threadlocal_context' of github.com:satac2/o…
a2c81b3 
…pentelemetry-cpp into runtime_and_threadlocal_context
@satac2
minor changes and switch from RuntimeContext accepting a ptr
1d7549f
@satac2
added SetValue and GetValue static methods to Runtime Context
d803674
@satac2
removed commented out line
224f3ec
@satac2
removed unnecessary line
5e5033a
@satac2
providing default value for parameters
4605bb1
@satac2
fixed nits
090fbe7
@satac2
added const to Top
2ba7e02
@satac2
Merge branch 'runtime_and_threadlocal_context' into context_helper_fu…
dfe09be 
…nctions
@satac2
added more comments
6779bf9
@satac2
Merge remote-tracking branch 'origin/master' into context_helper_func…
1141e41 
…tions
@satac2 satac2 requested a review from a team July 28, 2020 13:45
@satac2
Copy link
Contributor Author

satac2 commented Jul 28, 2020

Added static helper methods to RuntimeContext. @reyang @pyohannes

@codecov
Copy link

codecov bot commented Jul 28, 2020 •
edited
Loading

Codecov Report

Merging #225 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   93.75%   93.75%           
=======================================
  Files         104      104           
  Lines        3249     3249           
=======================================
  Hits         3046     3046           
  Misses        203      203

reyang
reyang approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang added the pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.) label Jul 29, 2020
@reyang reyang merged commit 4e2aeee into open-telemetry:master Jul 29, 2020
ziqizh pushed a commit to ziqizh/opentelemetry-cpp that referenced this pull request Jul 31, 2020
@satac2 @ziqizh
Context helper functions (open-telemetry#225)
f1e8b81
ziqizh pushed a commit to ziqizh/opentelemetry-cpp that referenced this pull request Jul 31, 2020
@satac2 @ziqizh
Context helper functions (open-telemetry#225)
ec0b87e
@reyang reyang mentioned this pull request Aug 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

Assignees
No one assigned
Labels
pr:please-merge This PR is ready to be merged by a Maintainer (rebased, CI passed, has enough valid approvals, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satac2 @reyang @maxgolov