Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context api actual methods #13

Merged
merged 45 commits into from
Jul 14, 2020
Merged

Context api actual methods #13

merged 45 commits into from
Jul 14, 2020

Conversation

satac2
Copy link
Owner

@satac2 satac2 commented Jul 13, 2020

Updated the branch to have actual methods, removed the Key Object and added a context_value variant.

Johannes Tax and others added 30 commits June 8, 2020 16:52
Add a minimal tracer example (open-telemetry#86)
2973baa
Set span start and end timestamps (open-telemetry#98)
58736f0
@HudsonHumphries
Add Useful Resources and Example Build Instructions to CONTRIBUTING.md (
9e5924c 
open-telemetry#97)
@reyang
Update maintainers/approvers (open-telemetry#107)
b395e1a
@Brandon-Kimberly
Migrate CI pipeline from CircleCI to GitHub Actions (open-telemetry#103)
422b7a4
Fix AtomicSharedPtr for C++20 (open-telemetry#114)
668bb8b
@reyang
Remove Josh from the approvers (open-telemetry#116)
b472384
@maxgolov
std::result_of removed in C++20 (open-telemetry#115)
49eee20
@tigrannajaryan
Remove Tigran Najaryan from Approvers list (open-telemetry#120)
9048d45 
I haven't been able to contribute to this SIG. Please remove me.
Will be glad to return if I get a chance to work on C++ in the future. :-)
@ankit-bhargava
Enhancements to PR open-telemetry#86 Add minimal tracer example (open…
c86794e 
…-telemetry#94)
@Brandon-Kimberly
Add code coverage using codecov.io (open-telemetry#121)
1a54e5d
Support for attributes on spans (open-telemetry#117)
9b624b9
@ziqizh
Add sampler header file (open-telemetry#118)
70d86d5
@ziqizh
SamplingResult attributes fix (open-telemetry#126)
6cb38fa
@nholbrook
Always Off Sampler (open-telemetry#125)
ed0a36e
@ziqizh
Always on sampler (open-telemetry#122)
79b6141
@maxgolov
Add compare operators to nostd::string_view (open-telemetry#124)
aa79d9c 
* Add compare operators to nostd::string_view

* Added tests
@jajanet
Start zPages README (open-telemetry#131)
f399bf5
@nadiaciobanu
Implement basic OTLP Recordable (open-telemetry#127)
5f4a464
@nadiaciobanu
Update OpenTelemetry protobuf definitions (open-telemetry#140)
7486a29
@satac2
added context header with dummy methods
4128a69
@satac2
Build and CMake files
cba6d5f
@satac2
auto formatted
b2e876e
@ziqizh
Sampler tracer integration (open-telemetry#128)
65f6639
@huyan0
Add badges to README.md (open-telemetry#157)
5bcf2d5
@nadiaciobanu
Add basic OTLP exporter (open-telemetry#152)
0cf5519
@satac2
changed variable name from attributes to values
a7480c8
@satac2 @reyang
Update api/include/opentelemetry/context/context.h
96cd32f 
Co-authored-by: Reiley Yang <reyang@microsoft.com>
@ziqizh
Parent-or-else Sampler (open-telemetry#142)
d2f979b
Don't move a constant AttributeValue (open-telemetry#141)
9aa4797
@satac2 satac2 requested review from 0x4b and adityashirodkar July 13, 2020 14:51
adityashirodkar
adityashirodkar approved these changes Jul 13, 2020
View reviewed changes
Copy link
Collaborator

@adityashirodkar adityashirodkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@satac2 satac2 merged commit f016689 into master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adityashirodkar adityashirodkar adityashirodkar approved these changes

@0x4b 0x4b 0x4b approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.