Bazel Build alterations #416
Conversation
TL;DR: Consumers of the bazel build can define their own dependencies prior to importing OTel and we will attempt to use their build/versions rather than our own.
Codecov Report
@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 94.58% 94.58%
=======================================
Files 179 179
Lines 7677 7677
=======================================
Hits 7261 7261
Misses 416 416
|
| ], | ||
| ) | ||
| # Load our direct dependencies. | ||
| opentelemetry_cpp_deps() |
There was a problem hiding this comment.
+1 on these changes. The root WORKSPACE looks much cleaner now : )
| native.local_repository, | ||
| name = "com_google_googletest", | ||
| path = "third_party/googletest", | ||
| ) |
There was a problem hiding this comment.
Nice. We are using google-test and benchmark from submodules directory now : )
|
|
||
| # OTLP Protocol definition | ||
| maybe( | ||
| native.new_local_repository, |
There was a problem hiding this comment.
This seems coming from the WORKSPACE file, but still wondering why OTLP protocol definition is native.new_local_repository but others are native.local_repository?
There was a problem hiding this comment.
That's the difference between something that HAS a bazel-build already, or one where we're adapting it to be a BAZEL workspace.
OTLP does NOT have a bazel build, so we're provding our own build file.
| # Google Benchmark library. | ||
| # Only needed for benchmarks, not to build the OpenTelemetry library. | ||
| maybe( | ||
| native.local_repository, |
There was a problem hiding this comment.
Are consumers of otel-cpp meant to load e.g. benchmark before calling opentelemetry_cpp_deps()?
There was a problem hiding this comment.
yeah. I need to write the "INSTALLING" section for bazel, but basic gist is if you want to configure your own version/build that you can do so if you load BEFORE calling our macro, but you'll be on your own ensuring the version is compatible with us.
This PR attempts to do the following:
Note: This follows OpenCensusCpp implementation pretty closely
Note: These submodules are NOT locked to version/tags, but really should be. Also, lack of SHA verification has me concerned. I'm not sure what the git submodule equivalent of this is.