Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Jaeger exporter target #918

Merged
merged 5 commits into from
Jul 22, 2021

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Jul 21, 2021

Changes

The otel-cpp targets are prefixed with opentelemetry, and exporters with opentelemetry_exporter. Renamed jaeger exporter target to be consistent with that. This is how the final targets look like:

$ ls -ltr /usr/local/lib/libopentelemetry_*
-rw-r--r-- 1 root root 3852102 Jul 21 20:21 /usr/local/lib/libopentelemetry_exporter_zipkin_trace.a
-rw-r--r-- 1 root root 3542158 Jul 21 21:15 /usr/local/lib/libopentelemetry_exporter_jaeger_trace.a
-rw-r--r-- 1 root root 4948736 Jul 21 21:26 /usr/local/lib/libopentelemetry_proto.a
-rw-r--r-- 1 root root    3116 Jul 21 21:27 /usr/local/lib/libopentelemetry_version.a
-rw-r--r-- 1 root root   67056 Jul 21 21:27 /usr/local/lib/libopentelemetry_common.a
-rw-r--r-- 1 root root 2894382 Jul 21 21:27 /usr/local/lib/libopentelemetry_resources.a
-rw-r--r-- 1 root root 3556204 Jul 21 21:27 /usr/local/lib/libopentelemetry_trace.a
-rw-r--r-- 1 root root 2805392 Jul 21 21:27 /usr/local/lib/libopentelemetry_exporter_ostream_span.a
-rw-r--r-- 1 root root  498176 Jul 21 21:27 /usr/local/lib/libopentelemetry_otlp_recordable.a
-rw-r--r-- 1 root root 6829052 Jul 21 21:28 /usr/local/lib/libopentelemetry_zpages.a
-rw-r--r-- 1 root root 1159478 Jul 21 21:28 /usr/local/lib/libopentelemetry_exporter_otlp_http.a
-rw-r--r-- 1 root root  259864 Jul 21 21:28 /usr/local/lib/libopentelemetry_exporter_otlp_grpc.a

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@lalitb lalitb requested a review from a team July 21, 2021 16:12
@codecov
Copy link

codecov bot commented Jul 21, 2021

Codecov Report

Merging #918 (b14d585) into main (db8289f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #918   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         158      158           
  Lines        6749     6749           
=======================================
  Hits         6441     6441           
  Misses        308      308           

@lalitb lalitb merged commit 950f940 into open-telemetry:main Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants