Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix exporting of Jaeger exporter target name #925

Merged
merged 4 commits into from
Jul 26, 2021

Conversation

seemk
Copy link
Contributor

@seemk seemk commented Jul 26, 2021

I believe it was introduced in #918

When doing make install the generated opentelemetry-cpp-config.cmake was trying to find a non-existent target, thus the OPENTELEMETRY_CPP_LIBRARIES variable did not have Jaeger exporter set.

@seemk seemk requested a review from a team July 26, 2021 12:56
@codecov
Copy link

codecov bot commented Jul 26, 2021

Codecov Report

Merging #925 (4f6a8ad) into main (1f31341) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #925   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files         158      158           
  Lines        6749     6749           
=======================================
  Hits         6441     6441           
  Misses        308      308           

@lalitb
Copy link
Member

lalitb commented Jul 26, 2021

Sorry, my bad. Thanks for raising the PR for the fix.
Just wondering if we should instead revert the EXPORT_NAME to jaeger_trace_exporer to be consistent with how other targets are listed in OPENTELEMETRY_CPP_LIBRARIES variable.

PROPERTIES EXPORT_NAME opentelemetry_exporter_jaeger_trace)

@seemk
Copy link
Contributor Author

seemk commented Jul 26, 2021

Sorry, my bad. Thanks for raising the PR for the fix.
Just wondering if we should instead revert the EXPORT_NAME to jaeger_trace_exporer to be consistent with how other targets are listed in OPENTELEMETRY_CPP_LIBRARIES variable.

PROPERTIES EXPORT_NAME opentelemetry_exporter_jaeger_trace)

Thanks! Changed the export name instead 👍

@lalitb lalitb merged commit 041df24 into open-telemetry:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants