Frontend spans are exploding cardinality by including request query params #1665
Labels
bug
Something isn't working
Comments
|
Proposed short term fix is to use an OTTL filter to correct this while waiting for the upstream library fix to be merged: vercel/next.js#64852 |
joshleecreates
added a commit
to joshleecreates/opentelemetry-demo
that referenced
this issue
Jul 14, 2024
- adds a transform processor
- adds two rules for transforming span names:
- Strip anything after a "?"
- Replace productID with a token in "GET /api/products/{productID}"
spans
joshleecreates
added a commit
to joshleecreates/opentelemetry-demo
that referenced
this issue
Jul 14, 2024
- adds a transform processor
- adds two rules for transforming span names:
- Strip anything after a "?"
- Replace productID with a token in "GET /api/products/{productID}"
spans
2 tasks
puckpuck
pushed a commit
that referenced
this issue
Jul 16, 2024
* Fixes #1665 Query Params in Span Name - adds a transform processor - adds two rules for transforming span names: - Strip anything after a "?" - Replace productID with a token in "GET /api/products/{productID}" spans * fix lint errors * update changelog --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
ahealy-newr
pushed a commit
to ahealy-newr/opentelemetry-demo-ahealy
that referenced
this issue
Jul 24, 2024
* Fixes open-telemetry#1665 Query Params in Span Name - adds a transform processor - adds two rules for transforming span names: - Strip anything after a "?" - Replace productID with a token in "GET /api/products/{productID}" spans * fix lint errors * update changelog --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Report
Which version of the demo you are using?
14e7f8f66c986cffa73a4314cb9c0f0e7e16a89e
Symptom
The URL query parameters are being included in the Span Name for spans coming from the next.js instrumentation library. This is causing exploding cardinality on the span name field which @puckpuck postulates is also causing Prometheus issues.
What is the expected behavior?
Span names should conform to the specification and should not include high-cardinality parameters.
What is the actual behavior?
Span names include all query parameters, including productID and sessionID
Reproduce
Run the demo and observe the number of operations in Jaeger on frontend.
Additional Context
Slack Thread
The text was updated successfully, but these errors were encountered: