Remove query params and product ID from span names #1668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
helm-update-required
- adds a transform processor
- adds two rules for transforming span names:
- Strip anything after a "?"
- Replace productID with a token in "GET /api/products/{productID}"
spans
joshleecreates
force-pushed
the
issue-1665-full-url-spannames
branch
from
2da796c
to
cf519ec
Compare
julianocosta89
approved these changes
Jul 15, 2024
|
We should add a changelog for this |
puckpuck
approved these changes
Jul 16, 2024
joshleecreates
force-pushed
the
issue-1665-full-url-spannames
branch
from
230c434
to
d3ded34
Compare
ahealy-newr
pushed a commit
to ahealy-newr/opentelemetry-demo-ahealy
that referenced
this pull request
Jul 24, 2024
* Fixes open-telemetry#1665 Query Params in Span Name - adds a transform processor - adds two rules for transforming span names: - Strip anything after a "?" - Replace productID with a token in "GET /api/products/{productID}" spans * fix lint errors * update changelog --------- Co-authored-by: Juliano Costa <julianocosta89@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Merge Requirements
For new features contributions please make sure you have completed the following
essential items:
CHANGELOG.mdupdated to document new feature additions* [ ] Appropriate documentation updates in the [docs][]