Skip to content

Commit

Permalink
AggregatorStore: don't double-count drops in doubles (#5193)
Browse files Browse the repository at this point in the history
  • Loading branch information
NickCraver authored Dec 19, 2023
1 parent 63fe0f3 commit 9d8ef70
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/OpenTelemetry/Metrics/AggregatorStore.cs
Original file line number Diff line number Diff line change
Expand Up @@ -1033,7 +1033,6 @@ private void UpdateDouble(double value, ReadOnlySpan<KeyValuePair<string, object
OpenTelemetrySdkEventSource.Log.MeasurementDropped(this.name, this.metricPointCapHitMessage, MetricPointCapHitFixMessage);
}

Interlocked.Increment(ref this.DroppedMeasurements);
return;
}
}
Expand Down Expand Up @@ -1078,7 +1077,6 @@ private void UpdateDoubleCustomTags(double value, ReadOnlySpan<KeyValuePair<stri
OpenTelemetrySdkEventSource.Log.MeasurementDropped(this.name, this.metricPointCapHitMessage, MetricPointCapHitFixMessage);
}

Interlocked.Increment(ref this.DroppedMeasurements);
return;
}
}
Expand Down

0 comments on commit 9d8ef70

Please sign in to comment.