AggregatorStore: don't double-count drops in doubles #5193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As funny as double counting only in doubles is, this seems like an oversight where we inadvertently call `Interlocked.Increment(ref this.DroppedMeasurements);` twice in the non-`emitOverflowAttribute` path. I noticed this digging into a related issue, so thought I'd pop up a PR while in here :)
|
|
utpilla
approved these changes
Dec 19, 2023
|
@NickCraver Thanks for sending the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As funny as double counting only in doubles is, this seems like an oversight where we inadvertently call
Interlocked.Increment(ref this.DroppedMeasurements);twice in the non-emitOverflowAttributepath. I noticed this digging into a related issue, so thought I'd pop up a PR while in here :)Changes
DroppedMeasurementsincrement inAggregatorStore.UpdateDoubleDroppedMeasurementsincrement inAggregatorStore.UpdateDoubleCustomTagsMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes