POC - Almost complete templated solution for ASP.Net Core MVC prometheus metrics Exporter #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysma500
requested review from
austinlparker,
discostu105,
lmolkova and
SergeyKanzhelev
as code owners
cijothomas
reviewed
Sep 30, 2019
| { | ||
| public MetricExporter MetricsExp; | ||
| private string _json; | ||
| public MetricShim(string jsonString) |
There was a problem hiding this comment.
perhaps a better solution would be use ConfigurationProvider from asp.net core itself, instead of doing parsing of json file. That'll allow config not just from appsettings.json, but from other providers as well (like env variable etc).
https://docs.microsoft.com/en-us/aspnet/core/fundamentals/configuration/?view=aspnetcore-3.0
|
I'm closing this PR as it's quite old and uses Stats while we are moving towards Mertrics API. |
Yun-Ting
pushed a commit
to Yun-Ting/opentelemetry-dotnet
that referenced
this pull request
Oct 13, 2022
…pen-telemetry#152) * Add WCF ServiceBehavior implementation. Resolves open-telemetry#142. * Update src/OpenTelemetry.Contrib.Instrumentation.Wcf/TelemetryServiceBehavior.cs Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com> * In response to PR open-telemetry#152 comments. Refactor common code that adds dispatch behavior to endpoint from both TelemetryServiceBehavior and TelemetryEndpointBehaviorUpdate src/OpenTelemetry.Contrib.Instrumentation.Wcf/TelemetryServiceBehavior.cs Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com> * Fixed lint errors in README & updated CHANGELOG. Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is a response to the Issue #124 .
Is a proof of concept.
Am open to new ideas.
Snipped from Issue #124 : "As a dev using ASP.Net Core MVC, I mainly use the file appsettings.json to assign different settings. We could use that file to do the heavy lifting of setting-up Prometheus Exporter."
It could be generalized by being able to use more than one Exporter under the MetricsShim.