Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimedEvents clean up #152

Merged
merged 1 commit into from
Jul 16, 2019
Merged

TimedEvents clean up #152

merged 1 commit into from
Jul 16, 2019

Conversation

lmolkova
Copy link

  • Eviction queue is repurposed and APIs cleaned up
  • EventsWithTime are removed in favor of TimedEvent
  • some minor clean ups

@lmolkova lmolkova merged commit 2183c42 into master Jul 16, 2019
@lmolkova lmolkova deleted the removeEvictionQueue branch July 26, 2019 17:43
Yun-Ting pushed a commit to Yun-Ting/opentelemetry-dotnet that referenced this pull request Oct 13, 2022
@Jaans @CodeBlanch
Add WCF ServiceBehavior implementation. Resolves open-telemetry#142. (o…
b907e05 
…pen-telemetry#152)

* Add WCF ServiceBehavior implementation. Resolves open-telemetry#142.

* Update src/OpenTelemetry.Contrib.Instrumentation.Wcf/TelemetryServiceBehavior.cs

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>

* In response to PR open-telemetry#152 comments. Refactor common code that adds dispatch behavior to endpoint from both TelemetryServiceBehavior and TelemetryEndpointBehaviorUpdate

src/OpenTelemetry.Contrib.Instrumentation.Wcf/TelemetryServiceBehavior.cs
Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>

* Fixed lint errors in README & updated CHANGELOG.

Co-authored-by: Mikel Blanchard <mblanchard@macrosssoftware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinlparker austinlparker austinlparker approved these changes

@discostu105 discostu105 Awaiting requested review from discostu105

@SergeyKanzhelev SergeyKanzhelev Awaiting requested review from SergeyKanzhelev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lmolkova @austinlparker