Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[repo] Add THIRD-PARTY-NOTICES file #5190

Merged
merged 3 commits into from
Dec 19, 2023

Conversation

CodeBlanch
Copy link
Member

Relates to #5187

Changes

  • Adds THIRD-PARTY-NOTICES file to include the dotnet\runtime MIT license info for the files we internalized (in src\Shared\EnvironmentVariables & src\Shared\Options)

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)

@CodeBlanch CodeBlanch requested a review from a team December 18, 2023 23:36
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (65dd83b) 83.47% compared to head (a539a59) 83.49%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5190      +/-   ##
==========================================
+ Coverage   83.47%   83.49%   +0.01%     
==========================================
  Files         297      297              
  Lines       12397    12398       +1     
==========================================
+ Hits        10349    10352       +3     
+ Misses       2048     2046       -2     
Flag Coverage Δ
unittests 83.49% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@utpilla utpilla merged commit 63fe0f3 into open-telemetry:main Dec 19, 2023
38 checks passed
@CodeBlanch CodeBlanch deleted the third-party-notices branch December 19, 2023 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants