-
Notifications
You must be signed in to change notification settings - Fork 765
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[repo] Update docs with third-party code inclusion guidance #5195
[repo] Update docs with third-party code inclusion guidance #5195
Conversation
CONTRIBUTING.md
Outdated
- The license of the file is | ||
[permissive](https://en.wikipedia.org/wiki/Permissive_free_software_licence). | ||
- The license of the file is left in-tact. | ||
- The contribution is correctly attributed in the [3rd party |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you be attributing the existing third-party code in the THIRD-PARTY-NOTICES.TXT
in some follow-up PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's what #5190 was all about. You think any more is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was checking the dotnet runtime repo's THIRD-PARTY-NOTICES.TXT
and their attributions are more specific where they list out the individual components/file copied along with the project URL that it's copied from.
I was wondering if we want to do that as well instead of having a blanket attribution to "Copyright (c) .NET Foundation and Contributors".
Just a thought. Not a blocker by any means.
This PR was marked stale due to lack of activity and will be closed in 7 days. Commenting or Pushing will instruct the bot to automatically remove the label. This bot runs once per day. |
@CodeBlanch just a few links that need fixing
|
@CodeBlanch FYI - adding opentelemetry-dotnet/docs/docfx.json Lines 28 to 33 in d73ed67
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5195 +/- ##
==========================================
- Coverage 83.44% 83.40% -0.04%
==========================================
Files 297 297
Lines 12531 12531
==========================================
- Hits 10456 10451 -5
- Misses 2075 2080 +5
Flags with carried forward coverage won't be shown. Click here to find out more. |
Relates to #5187
Changes
CONTRIBUTING.md
to have guidance for third-party code inclusion. Inspired by dotnet/runtime CONTRIBUTING.md.Merge requirement checklist