Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Activity parent in links example (readme) #946

Merged
merged 6 commits into from
Jul 30, 2020

Conversation

lmolkova
Copy link

Server activity had parent equal to one of the links - this is confusing, changed to default context (new trace) as likely this activity has no parent.

Server activity had parent equal to one of the links - this is confusing, changed to default context (new trace) as likely this activity has no parent.
@lmolkova lmolkova requested a review from a team July 29, 2020 21:44
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments.

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cijothomas cijothomas merged commit 70c4107 into master Jul 30, 2020
@cijothomas cijothomas deleted the lmolkova-patch-1 branch July 30, 2020 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants