Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Activity parent in links example (readme) #946

Merged
merged 6 commits into from
Jul 30, 2020
Merged

Clarify Activity parent in links example (readme) #946

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fb438cf
Clarify parent id in links scenario
Jul 29, 2020
d5e7b57
Update README.md
Jul 29, 2020
3a4c2dd
review comments
Jul 29, 2020
ae1a49d
Merge branch 'master' into lmolkova-patch-1
cijothomas Jul 30, 2020
b83a6ef
fix lint
Jul 30, 2020
b833cd6
Merge branch 'master' into lmolkova-patch-1
cijothomas Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions src/OpenTelemetry.Api/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,9 +270,22 @@ OpenTelemetry samplers chose not to sample this activity.
activityLinks.Add(new ActivityLink(linkedContext2));

var activity = activitySource.StartActivity(
"ActivityName",
"ActivityWithLinks",
ActivityKind.Server,
"00-0af7651916cd43dd8448eb211c80319c-b7ad6b7169203331-01",
default(ActivityContext), // this creates Activity without parent
initialTags,
activityLinks);
```

In case activity has parent, pass parent's context:

```csharp
var parentContext = Activity.Current != null ? Activity.Current.Context : default(ActivityContext);

var activity = activitySource.StartActivity(
"ActivityWithLinks",
ActivityKind.Server,
parentContext,
initialTags,
activityLinks);
```
Expand Down