Add db.name to ecto spans #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per the spec, the db.name attribute is required on database spans. This changes adds it. Ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#call-level-attributes
|
Thanks! Can you update the changelog? I also don't like that we have name in |
|
Done @tsloughter |
|
Looks good and ready once the formatting issues in CI are resolved. |
tsloughter
approved these changes
May 18, 2023
cedricziel
commented
May 22, 2023
instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs
Outdated
Show resolved
Hide resolved
cedricziel
commented
May 22, 2023
instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs
Outdated
Show resolved
Hide resolved
|
@tsloughter fixed the issues. Pretty embarrassing missing quotes .. |
This was referenced May 23, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the spec, the db.name attribute is required on database spans. This changes adds it.
Ref: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/trace/semantic_conventions/database.md#call-level-attributes