Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add db.name to ecto spans #172

Merged
merged 5 commits into from
May 23, 2023
Merged

Add db.name to ecto spans #172

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3ef5b91
Add db.name to ecto spans
cedricziel May 16, 2023
f57139c
Add db.name attribute to tests
cedricziel May 16, 2023
f431716
Changelog update
cedricziel May 16, 2023
805e175
Update instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_tes…
cedricziel May 22, 2023
8893af3
Update instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_tes…
cedricziel May 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions instrumentation/opentelemetry_ecto/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 1.1.1

### Changed

* Add db.name to ecto spans

## 1.1.0

### Changed
Expand Down
1 change: 1 addition & 0 deletions instrumentation/opentelemetry_ecto/lib/opentelemetry_ecto.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,7 @@ defmodule OpentelemetryEcto do
"db.statement": query,
source: source,
"db.instance": database,
"db.name": database,
"db.url": url,
"total_time_#{time_unit}s": System.convert_time_unit(total_time, :native, time_unit)
}
Expand Down
2 changes: 2 additions & 0 deletions instrumentation/opentelemetry_ecto/test/opentelemetry_ecto_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ defmodule OpentelemetryEctoTest do

assert %{
"db.instance": "opentelemetry_ecto_test",
"db.name": "opentelemetry_ecto_test",
"db.statement": "SELECT u0.\"id\", u0.\"email\" FROM \"users\" AS u0",
"db.type": :sql,
"db.url": "ecto://localhost",
Expand Down Expand Up @@ -82,6 +83,7 @@ defmodule OpentelemetryEctoTest do

assert %{
"db.instance": "opentelemetry_ecto_test",
"db.name": "opentelemetry_ecto_test",
"db.statement": "SELECT p0.\"id\", p0.\"body\", p0.\"user_id\" FROM \"posts\" AS p0",
"db.type": :sql,
"db.url": "ecto://localhost",
Expand Down