Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logr log bridge #5192

Closed
2 of 5 tasks
pellared opened this issue Mar 1, 2024 · 4 comments · Fixed by #6386
Closed
2 of 5 tasks

Add logr log bridge #5192

pellared opened this issue Mar 1, 2024 · 4 comments · Fixed by #6386
Assignees
@scorpionknifes
Labels
bridge: logr Related to the logr bridge enhancement New feature or request
Milestone
v1.33.0

Comments

@pellared
Copy link
Member

pellared commented Mar 1, 2024 •
edited
Loading

Add logr.LogSink log bridge.

Prototype implementation: https://github.com/pellared/opentelemetry-go/blob/147762ffb5c4394417b3f973274cc570723db79b/log/internal/logr.go

TODO:
@pellared pellared added the enhancement New feature or request label Mar 1, 2024
@pellared pellared mentioned this issue Mar 1, 2024
Closed
@pellared pellared moved this to Ready in Go: Logs (Post-GA) Mar 29, 2024
@scorpionknifes
Copy link
Member

Keen to pick this one up

@pellared
Copy link
Member Author

pellared commented Apr 3, 2024

@scorpionknifes You are assigned. I suggest also looking at https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/bridges/otelslog as reference.

@scorpionknifes scorpionknifes mentioned this issue Apr 3, 2024
Closed
@pellared pellared mentioned this issue Apr 24, 2024
Closed
@pellared
Copy link
Member Author

@scorpionknifes, I added "TODO" steps to the issue description

@scorpionknifes scorpionknifes mentioned this issue Sep 9, 2024
Merged
pellared added a commit that referenced this issue Sep 12, 2024
@scorpionknifes @pellared
Add skeleton for otellogr bridge (#6097)
4603866 
This PR is the skeleton for otellogr package, which provides a LogSink
to bridge the logging capabilities for Logr with OpenTelemetry

Part of #5192

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@scorpionknifes scorpionknifes mentioned this issue Sep 12, 2024
Merged
pellared pushed a commit that referenced this issue Sep 24, 2024
@scorpionknifes
otellogr: Implement Info, WithName, WithValues (#6111)
ac19587 
This PR implements a few methods for otellogr package
- Info
- WithName
- WithValues

Out of scope
- Enabled
- Init
- Error
- Level

Part of
#5192
@pellared pellared added the bridge: logr Related to the logr bridge label Oct 3, 2024
@scorpionknifes scorpionknifes mentioned this issue Oct 5, 2024
Merged
pellared added a commit that referenced this issue Oct 28, 2024
@scorpionknifes @pellared
otellogr: Implement LevelSeverity, Enabled (#6206)
1379d74 
This PR implements a few methods for otellogr package
- Configurable LevelSeverity
- Enabled

Part of
#5192

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@scorpionknifes scorpionknifes mentioned this issue Nov 5, 2024
Merged
dmathieu added a commit that referenced this issue Nov 14, 2024
@scorpionknifes @dmathieu @pellared
otellogr: Implement Error and comment Init (#6295)
5b9cf72 
Implements remaining methods and adds to the changelog

Part of
#5192

---------

Co-authored-by: Damien Mathieu <42@dmathieu.com>
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@scorpionknifes scorpionknifes mentioned this issue Nov 24, 2024
Merged
pellared pushed a commit that referenced this issue Nov 26, 2024
@scorpionknifes
otellogr: Add benchmarks (#6364)
91a1588 
Add benchmarks (similar to otelslog)
Part of
#5192

Benchmark results:
```
goos: linux
goarch: amd64
pkg: go.opentelemetry.io/contrib/bridges/otellogr
cpu: Intel(R) Core(TM) i9-10885H CPU @ 2.40GHz
BenchmarkLogSink/Info-16                 6114177               186.4 ns/op           160 B/op          1 allocs/op
BenchmarkLogSink/Error-16                6649935               245.2 ns/op           160 B/op          1 allocs/op
BenchmarkLogSink/WithValues-16           3949730               295.6 ns/op           448 B/op          3 allocs/op
BenchmarkLogSink/WithName-16             6813362               172.0 ns/op           133 B/op          2 allocs/op
BenchmarkLogSink/WithName.WithValues-16                  2420191               606.4 ns/op           581 B/op          5 allocs/op
BenchmarkLogSink/(WithName.WithValues).Info-16          12601381                97.32 ns/op            0 B/op          0 allocs/op
PASS
ok      go.opentelemetry.io/contrib/bridges/otellogr    24.125s
```
@pellared
Copy link
Member Author

pellared commented Nov 26, 2024 •
edited
Loading

@scorpionknifes, I think that at the point we can add otellogr to published modules.

I find it safer to track #5357 (comment) as a separate issue. We can even postpone its resolution until we get community feedback if it actually needed.

@pellared pellared moved this from Ready to In progress in Go: Logs (Post-GA) Nov 26, 2024
@scorpionknifes scorpionknifes mentioned this issue Dec 1, 2024
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Go: Logs (Post-GA) Dec 2, 2024
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scorpionknifes scorpionknifes

Labels
bridge: logr Related to the logr bridge enhancement New feature or request
Projects
Go: Logs (Post-GA)
Status: Done
Milestone
v1.33.0
Development

Successfully merging a pull request may close this issue.

otellogr: Publish module scorpionknifes/opentelemetry-go-contrib
3 participants
@pellared @MrAlias @scorpionknifes