-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add skeleton for otellogr bridge #6097
Merged
pellared
merged 8 commits into
open-telemetry:main
from
scorpionknifes:otellogr-skeleton
Sep 12, 2024
Merged
Add skeleton for otellogr bridge #6097
pellared
merged 8 commits into
open-telemetry:main
from
scorpionknifes:otellogr-skeleton
Sep 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6097 +/- ##
=====================================
Coverage 65.7% 65.7%
=====================================
Files 203 204 +1
Lines 13039 13083 +44
=====================================
+ Hits 8572 8605 +33
- Misses 4205 4215 +10
- Partials 262 263 +1
|
pellared
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can also update CODEOWNERS
in this PR if you want.
pellared
added
the
Skip Changelog
Allow PR to succeed without requiring an addition to the CHANGELOG
label
Sep 9, 2024
dmathieu
reviewed
Sep 10, 2024
dmathieu
approved these changes
Sep 10, 2024
scorpionknifes
requested review from
MrAlias,
MadVikingGod,
dashpole and
XSAM
as code owners
September 10, 2024 23:13
pellared
reviewed
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the skeleton for otellogr package, which provides a LogSink to bridge the logging capabilities for Logr with OpenTelemetry
Please add skip changelog thx 🙏
Part of #5192