Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skeleton for otellogr bridge #6097

Merged
merged 8 commits into from
Sep 12, 2024

Conversation

scorpionknifes
Copy link
Member

@scorpionknifes scorpionknifes commented Sep 9, 2024

This PR is the skeleton for otellogr package, which provides a LogSink to bridge the logging capabilities for Logr with OpenTelemetry

Please add skip changelog thx 🙏

Part of #5192

@scorpionknifes scorpionknifes requested a review from a team September 9, 2024 14:22
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 79.54545% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.7%. Comparing base (4ccc9c6) to head (8cd4286).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
bridges/otellogr/logsink.go 79.5% 9 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6097   +/-   ##
=====================================
  Coverage   65.7%   65.7%           
=====================================
  Files        203     204    +1     
  Lines      13039   13083   +44     
=====================================
+ Hits        8572    8605   +33     
- Misses      4205    4215   +10     
- Partials     262     263    +1     
Files with missing lines Coverage Δ
bridges/otellogr/logsink.go 79.5% <79.5%> (ø)

... and 1 file with indirect coverage changes

Copy link
Member

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also update CODEOWNERS in this PR if you want.

@pellared pellared added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Sep 9, 2024
CODEOWNERS Outdated Show resolved Hide resolved
@pellared pellared merged commit 4603866 into open-telemetry:main Sep 12, 2024
27 checks passed
@MrAlias MrAlias added this to the v1.31.0 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants