Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate and remove go.opentelemetry.io/otel/detectors/aws/ec2 #5542

Closed
MrAlias opened this issue May 9, 2024 · 8 comments · Fixed by #5656
Closed

Deprecate and remove go.opentelemetry.io/otel/detectors/aws/ec2 #5542

MrAlias opened this issue May 9, 2024 · 8 comments · Fixed by #5656
Assignees
Labels
abandoned Relates to a module that has been abandoned and is scheduled for deprecation and removal detector: aws:ec2
Milestone

Comments

@MrAlias
Copy link
Contributor

MrAlias commented May 9, 2024

This module has been identified to not have an owner. Based on the project's ownership policy, this module will be deprecated and then removed.

How to keep this module

For this module to continue in this repository, it needs a sponsor.

If you would like to sponsor this module and become an owner, please comment in this issue about your desire. As an owner you will assume the following responsibilities:

  • You will need to be a member of the OpenTelemetry organization and maintain that membership.
    • If you are not an existing member, we can add you to the community. This is not a disqualification, but something you will need in the process of becoming a sponsor.
  • You will be responsible for keeping up with the instrumented library. Any "upstream" changes that impact this module need to be proactively handle by you.
  • You will be expected to review any Pull Requests or Issues created that relate to this module.
  • You will be responsible for the stability and versioning compliance of the module.

You will need to have a good working knowledge of the code this module is instrumenting and, ideally, familiarity with the existing module code.

How this module will be removed

This module is in the process of being deprecated. After that deprecation notice has been published, we will wait 3 months or 2 two releases (whichever is the longer time period). After that time period, this module will be removed from this repository and no more versions of the module will be published.

Resurrection

If a sponsor is found after the module has been deprecated or removed, these operations can be reversed (i.e. coded added back, deprecation notice removed).

@MrAlias MrAlias converted this from a draft issue May 9, 2024
@MrAlias MrAlias moved this from Todo to Sponsorship in Go: Remove unowned modules May 9, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented May 9, 2024

cc @Aneurysm9

@MrAlias MrAlias added the abandoned Relates to a module that has been abandoned and is scheduled for deprecation and removal label May 9, 2024
@MrAlias MrAlias self-assigned this May 22, 2024
@MrAlias MrAlias moved this from Sponsorship to Deprecating in Go: Remove unowned modules May 22, 2024
MrAlias added a commit that referenced this issue May 23, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented May 23, 2024

@pyohannes would like to become the owner of this.

@akats7
Copy link
Contributor

akats7 commented May 29, 2024

Hi @MrAlias @dmathieu, I'm also willing to become code owner for this

@MrAlias
Copy link
Contributor Author

MrAlias commented May 29, 2024

@akats7 thanks for the interest! Can you review the Code Ower policy and comment if you meet the requirements and are comfortable assuming the responsibilities?

@wangzlei
Copy link
Contributor

wangzlei commented May 30, 2024

@Aneurysm9 @MrAlias I'm willing to be code owner for this component

@jj22ee
Copy link
Contributor

jj22ee commented May 30, 2024

Hi, I can be a code owner for this component
cc @Aneurysm9 @MrAlias

MrAlias added a commit that referenced this issue May 31, 2024
Closes #5542 
Closes #5543 
Closes #5544 

@pyohannes please be sure to review our [CODEOWNER
policy](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/CONTRIBUTING.md#code-owners).
If you are okay with accepting the responsibilities, please approve this
PR.

---------

Co-authored-by: Robert Pająk <pellared@hotmail.com>
@github-project-automation github-project-automation bot moved this from Deprecating to Done in Go: Remove unowned modules May 31, 2024
@MrAlias MrAlias reopened this May 31, 2024
@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 3, 2024

@jj22ee linking my response from here:

@jj22ee I see you are not already a CNCF project member . This is one of the requirements we have for becoming a Code Owner.

I'm going to hold off on adding you as a Code Owner for now. If you do become a CNCF member in the future and still wish to be a Code Owner of this module, please open an issue to apply then.

@MrAlias
Copy link
Contributor Author

MrAlias commented Jun 3, 2024

@Aneurysm9 @MrAlias I'm willing to be code owner for this component

Awesome @wangzlei! It looks like you meet all the requirements to become a Code Owner of this module. I will open a PR to add you once #5712 merges (to help prevent merge conflicts).

MrAlias added a commit that referenced this issue Jun 5, 2024
cc @akats7 

- `go.opentelemetry.io/otel/detectors/aws/ec2`
- `go.opentelemetry.io/otel/detectors/aws/ecs`
- `go.opentelemetry.io/otel/detectors/aws/lambda`
-
`go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-lambda-go/otellambda`
-
`go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`
-
`go.opentelemetry.io/contrib/instrumentation/github.com/gorilla/mux/otelmux`
- `go.opentelemetry.io/contrib/propagators/aws`

Part of
#5542
Part of
#5543
Part of
#5545
Part of
#5546
Part of
#5547
Part of
#5549
Part of
#5553
@MrAlias MrAlias closed this as completed Jun 20, 2024
@MrAlias MrAlias added this to the v1.28.0 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
abandoned Relates to a module that has been abandoned and is scheduled for deprecation and removal detector: aws:ec2
Projects
4 participants