Move google.golang.org/grpc instrumentation from go.opentelemetry.io/otel
#156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
requested review from
Aneurysm9,
evantorrie,
jmacd and
lizthegrey
as code owners
MrAlias
added a commit
to MrAlias/opentelemetry-go
that referenced
this pull request
Jul 28, 2020
|
Need to cut a release of go.opentelemetry.io/otel before I can fix the dependencies of the example here. |
MrAlias
added
the
blocked: opentelemetry-go
|
Reattempt after the upcoming release of |
plantfansam
referenced
this pull request
in plantfansam/opentelemetry-go-contrib
Mar 18, 2022
* WIP * Finish http middleware implementation This is currently done as httptrace.NewHandler(). This should maybe be moved to a different package or renamed, but atm this name seemed the least objectionable to me. There are a few TODOs sprinkled in the code for questions I didn't know the answers to. There is an example provided, which when copied to a main func locally work against the jaeger all in one. Real tests need to be added. * Address feedback * Tie in propagation, update attributes, more options, revise example, etc. Dropped the httpConfig type because it seemed redundant an unecessary abstraction. * WithRouteTag * address out of band feedback * move to othttp package * Add a very basic test. I ended up needing to export the Traceparentheader const so that it was accessible to this test. * Add file header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go.opentelemetry.io/contrib/google.golang.org/grpcPart of https://github.com/open-telemetry/opentelemetry-go/issues/976