Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move gRPC instrumentation from go.opentelemetry.io/otel #189

Merged
merged 10 commits into from
Aug 6, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Aug 4, 2020

This is as direct as possible copy of the existing gRPC instrumentation and examples from the OTel repository.

The small changes included are:

  • Includes a package rename: go.opentelemetry.io/contrib/google.golang.org/grpc
  • Packages it as its own module.

Part of https://github.com/open-telemetry/opentelemetry-go/issues/976

Superseeds #156

@MrAlias MrAlias added the area: instrumentation Related to an instrumentation package label Aug 4, 2020
@MrAlias MrAlias self-assigned this Aug 4, 2020
MrAlias added a commit to MrAlias/opentelemetry-go that referenced this pull request Aug 4, 2020
This is being moved to the contrib repo with
open-telemetry/opentelemetry-go-contrib#189
as part of #976.
@MrAlias MrAlias marked this pull request as draft August 4, 2020 18:08
@MrAlias MrAlias marked this pull request as ready for review August 4, 2020 18:49
@MrAlias MrAlias merged commit 87806b1 into open-telemetry:master Aug 6, 2020
@MrAlias MrAlias deleted the grpc branch August 6, 2020 03:17
MrAlias added a commit to open-telemetry/opentelemetry-go that referenced this pull request Aug 6, 2020
* Remove grpctrace package

This is being moved to the contrib repo with
open-telemetry/opentelemetry-go-contrib#189
as part of #976.

* Update Changelog

* Remove the grpc example

Moved to contrib repo

* Fix spelling error

* Update Changelog
@MrAlias MrAlias mentioned this pull request Aug 13, 2020
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
shbieng added a commit to shbieng/opentelemetry-go that referenced this pull request Aug 26, 2022
* Remove grpctrace package

This is being moved to the contrib repo with
open-telemetry/opentelemetry-go-contrib#189
as part of #976.

* Update Changelog

* Remove the grpc example

Moved to contrib repo

* Fix spelling error

* Update Changelog
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: instrumentation Related to an instrumentation package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants