gorilla/mux instrumentation #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krnowak
requested review from
jmacd,
lizthegrey,
MrAlias,
paivagustavo,
rghetia and
tedsuo
as code owners
|
cc @paulosman to have a look and see whether the approach is similar to, or wildly dissimilar from https://github.com/honeycombio/beeline-go/tree/master/wrappers/hnygorilla |
MrAlias
reviewed
Apr 22, 2020
|
Updated, it's independent from #15, so it's ready for review. |
Merged
MrAlias
reviewed
Apr 24, 2020
MikeGoldsmith
approved these changes
Apr 25, 2020
|
Updated. |
MrAlias
approved these changes
Apr 28, 2020
Aneurysm9
approved these changes
May 2, 2020
MikeGoldsmith
added a commit
to MikeGoldsmith/opentelemetry-go-contrib
that referenced
this pull request
May 11, 2020
* master: Runtime metrics plugin (open-telemetry#9) Fix issues raised by golangci-lint (open-telemetry#29) use correct circleci dir (open-telemetry#30) gorilla/mux instrumentation (open-telemetry#19) Update CODEOWNERS and CONTRIBUTING.md to match otel-go (open-telemetry#27) Dogstatsd exporter resource support (for 0.4.3 release) (open-telemetry#25) add datadog metrics exporter (open-telemetry#22) Update codeowners and maintainers (open-telemetry#21) # Conflicts: # go.mod # go.sum # internal/trace/http.go
This was referenced Jun 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs PR #15 to be merged first! When it's merged, I'll rebase the branch. For now, posting the code for review. The code is inplugins/gorilla/mux.This PR adds a mock tracer needed for instrumentation tests, functions for getting attributes from the HTTP request and an instrumentation code.