Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add datadog metrics exporter #22

Merged
merged 1 commit into from
Apr 27, 2020
Merged

Conversation

marwan-at-work
Copy link
Contributor

@marwan-at-work marwan-at-work commented Apr 24, 2020

Fixes marwan-at-work/otel-exporter-datadog#3

This exporter uses the official DataDog client and is modeled after the OpenCensus exporter that they have written https://github.com/DataDog/opencensus-go-exporter-datadog

Copy link
Contributor

@jmacd jmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I'm mostly concerned about the question about copyright requirements.

exporters/metric/datadog/datadog.go Show resolved Hide resolved
exporters/metric/datadog/datadog.go Show resolved Hide resolved
@jmacd
Copy link
Contributor

jmacd commented Apr 24, 2020

FYI the OTel Resources will be coming through the export pipeline, soon. open-telemetry/opentelemetry-go#659

@marwan-at-work
Copy link
Contributor Author

@jmacd thanks -- is there any documentation on Resources? What are they and how can this exporter use them?

Thanks again for all the help!

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this exporter be hosted by DataDog like all the other vendor exporters?

@jmacd jmacd merged commit 83131c9 into open-telemetry:master Apr 27, 2020
@jmacd
Copy link
Contributor

jmacd commented Apr 27, 2020

@lizthegrey @MrAlias I filed an issue in the DD repo: DataDog/datadog-go#146

MikeGoldsmith added a commit to MikeGoldsmith/opentelemetry-go-contrib that referenced this pull request May 11, 2020
* master:
  Runtime metrics plugin (open-telemetry#9)
  Fix issues raised by golangci-lint (open-telemetry#29)
  use correct circleci dir (open-telemetry#30)
  gorilla/mux instrumentation (open-telemetry#19)
  Update CODEOWNERS and CONTRIBUTING.md to match otel-go (open-telemetry#27)
  Dogstatsd exporter resource support (for 0.4.3 release) (open-telemetry#25)
  add datadog metrics exporter (open-telemetry#22)
  Update codeowners and maintainers (open-telemetry#21)

# Conflicts:
#	go.mod
#	go.sum
#	internal/trace/http.go
plantfansam referenced this pull request in plantfansam/opentelemetry-go-contrib Mar 18, 2022
* rename Log and Logf interface to AddEvent and AddEventf.
- also remove log package.

* provide only AddEvent interface to Span
- Event can be created using Event specific interface.

* add var trick for Event interface.
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider moving this package to OTel-Go-Contrib
5 participants