Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otelgin): remove redundant error handling from HTML #6373

Merged
merged 8 commits into from
Nov 27, 2024
Merged

fix(otelgin): remove redundant error handling from HTML #6373

merged 8 commits into from
Nov 27, 2024

Conversation

flc1125
Copy link
Member

@flc1125 flc1125 commented Nov 26, 2024

Originating from #5088 (comment)

@flc1125 flc1125 requested a review from a team as a code owner November 26, 2024 14:36
pellared
pellared reviewed Nov 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
pellared
pellared reviewed Nov 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@flc1125 @pellared
Update CHANGELOG.md
5b5b7f3 
Co-authored-by: Robert Pająk <pellared@hotmail.com>
@codecov Codecov
Copy link

codecov bot commented Nov 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.9%. Comparing base (dfd6b16) to head (b542412).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6373   +/-   ##
=====================================
  Coverage   66.9%   66.9%           
=====================================
  Files        193     193           
  Lines      15654   15647    -7     
=====================================
- Hits       10482   10481    -1     
+ Misses      4881    4876    -5     
+ Partials     291     290    -1
Files with missing lines Coverage Δ
...ation/github.com/gin-gonic/gin/otelgin/gintrace.go 89.8% <100.0%> (+5.5%) ⬆️

dmathieu
dmathieu reviewed Nov 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@flc1125 @dmathieu
Update CHANGELOG.md
5921269 
Co-authored-by: Damien Mathieu <42@dmathieu.com>
@flc1125 flc1125 mentioned this pull request Nov 27, 2024
Closed
6 tasks
@pellared pellared changed the title chore(otelgin): remove redundant error handling in gintrace.go chore(otelgin): remove redundant error handling in HTML Nov 27, 2024
@pellared pellared changed the title chore(otelgin): remove redundant error handling in HTML chore(otelgin): remove redundant error handling from HTML Nov 27, 2024
@pellared pellared changed the title chore(otelgin): remove redundant error handling from HTML fix(otelgin): remove redundant error handling from HTML Nov 27, 2024
@pellared pellared merged commit 251d2d4 into open-telemetry:main Nov 27, 2024
25 checks passed
@flc1125 flc1125 deleted the otelgin-remove-html-panic branch November 27, 2024 11:31
@MrAlias MrAlias added this to the v1.33.0 milestone Dec 11, 2024
@MrAlias MrAlias mentioned this pull request Dec 12, 2024
Merged
MrAlias added a commit that referenced this pull request Dec 12, 2024
@MrAlias
Release v1.33.0/v0.58.0/v0.27.0/v0.13.0/v0.8.0/v0.6.0/v0.5.0 (#6435)
f6667f6 
### Added

- Added support for providing `endpoint`, `pollingIntervalMs` and
`initialSamplingRate` using environment variable
`OTEL_TRACES_SAMPLER_ARG` in
`go.opentelemetry.io/contrib/samples/jaegerremote`. (#6310)
- Added support exporting logs via OTLP over gRPC in
`go.opentelemetry.io/contrib/config`. (#6340)
- The `go.opentelemetry.io/contrib/bridges/otellogr` module.
This module provides an OpenTelemetry logging bridge for
`github.com/go-logr/logr`. (#6386)
- Added SNS instrumentation in
`go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`.
(#6388)

### Changed

- Change the span name to be `GET /path` so it complies with the OTel
HTTP semantic conventions in
`go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho`.
(#6365)
- Record errors instead of setting the `gin.errors` attribute in
`go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`.
(#6346)
- The `go.opentelemetry.io/contrib/config` now supports multiple schemas
in subdirectories (i.e. `go.opentelemetry.io/contrib/config/v0.3.0`) for
easier migration. (#6412)

### Fixed

- Fix broken AWS presigned URLs when using instrumentation in
`go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`.
(#5975)
- Fixed the value for configuring the OTLP exporter to use `grpc`
instead of `grpc/protobuf` in `go.opentelemetry.io/contrib/config`.
(#6338)
- Allow marshaling types in `go.opentelemetry.io/contrib/config`.
(#6347)
- Removed the redundant handling of panic from the `HTML` function in
`go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`.
(#6373)
- The `code.function` attribute emitted by
`go.opentelemetry.io/contrib/bridges/otelslog` now stores just the
function name instead the package path-qualified function name. The
`code.namespace` attribute now stores the package path. (#6415)
- The `code.function` attribute emitted by
`go.opentelemetry.io/contrib/bridges/otelzap` now stores just the
function name instead the package path-qualified function name. The
`code.namespace` attribute now stores the package path. (#6423)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pellared pellared pellared approved these changes

@MrAlias MrAlias MrAlias approved these changes

@dmathieu dmathieu dmathieu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.33.0
Development

Successfully merging this pull request may close these issues.
4 participants
@flc1125 @dmathieu @pellared @MrAlias