feat(otelaws): add sns attribute instrumentation #6388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need a changelog entry. |
pragmaticivan
force-pushed
the
instrument-aws-sns-go-v2
branch
from
091283b to
c8def81
Compare
|
Thanks @dmathieu ! |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6388 +/- ##
=====================================
Coverage 67.7% 67.8%
=====================================
Files 199 200 +1
Lines 16564 16589 +25
=====================================
+ Hits 11229 11251 +22
- Misses 4993 4995 +2
- Partials 342 343 +1
|
MrAlias
reviewed
Dec 2, 2024
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes_test.go
Outdated
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes_test.go
Show resolved
Hide resolved
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes_test.go
Show resolved
Hide resolved
akats7
reviewed
Dec 2, 2024
instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go
Outdated
Show resolved
Hide resolved
pragmaticivan
force-pushed
the
instrument-aws-sns-go-v2
branch
2 times, most recently
from
11d1c29 to
337ad38
Compare
MrAlias
approved these changes
Dec 8, 2024
|
Checking what's going with the tests, something odd there after the merge conflict. |
feat(otelaws): also instrument PublishBatchInput doc: add entry to changelog chore: sns package indirect Update instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Update instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> Update instrumentation/github.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com> revert - Update CHANGELOG.md chore: add missin assertions and use context background in tests chore: add test for input wihtout destination chore(build): fix conflicts chore(build): fix conflicts
pragmaticivan
force-pushed
the
instrument-aws-sns-go-v2
branch
from
337ad38 to
ea77683
Compare
Fixed, no errors at the end.
|
dmathieu
approved these changes
Dec 10, 2024
|
@akats7 does this look good to you? |
akats7
approved these changes
Dec 10, 2024
yep looks good, meant to approve earlier |
MrAlias
added a commit
that referenced
this pull request
Dec 12, 2024
### Added - Added support for providing `endpoint`, `pollingIntervalMs` and `initialSamplingRate` using environment variable `OTEL_TRACES_SAMPLER_ARG` in `go.opentelemetry.io/contrib/samples/jaegerremote`. (#6310) - Added support exporting logs via OTLP over gRPC in `go.opentelemetry.io/contrib/config`. (#6340) - The `go.opentelemetry.io/contrib/bridges/otellogr` module. This module provides an OpenTelemetry logging bridge for `github.com/go-logr/logr`. (#6386) - Added SNS instrumentation in `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`. (#6388) ### Changed - Change the span name to be `GET /path` so it complies with the OTel HTTP semantic conventions in `go.opentelemetry.io/contrib/instrumentation/github.com/labstack/echo/otelecho`. (#6365) - Record errors instead of setting the `gin.errors` attribute in `go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`. (#6346) - The `go.opentelemetry.io/contrib/config` now supports multiple schemas in subdirectories (i.e. `go.opentelemetry.io/contrib/config/v0.3.0`) for easier migration. (#6412) ### Fixed - Fix broken AWS presigned URLs when using instrumentation in `go.opentelemetry.io/contrib/instrumentation/github.com/aws/aws-sdk-go-v2/otelaws`. (#5975) - Fixed the value for configuring the OTLP exporter to use `grpc` instead of `grpc/protobuf` in `go.opentelemetry.io/contrib/config`. (#6338) - Allow marshaling types in `go.opentelemetry.io/contrib/config`. (#6347) - Removed the redundant handling of panic from the `HTML` function in `go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`. (#6373) - The `code.function` attribute emitted by `go.opentelemetry.io/contrib/bridges/otelslog` now stores just the function name instead the package path-qualified function name. The `code.namespace` attribute now stores the package path. (#6415) - The `code.function` attribute emitted by `go.opentelemetry.io/contrib/bridges/otelzap` now stores just the function name instead the package path-qualified function name. The `code.namespace` attribute now stores the package path. (#6423)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
semconv/v1.27.0was available in the latest published version of the otel module.m.initializeMiddlewareBefore, m.initializeMiddlewareAfter, m.finalizeMiddlewareAfter, m.deserializeMiddleware). All attributes are currently being set oninitializeMiddlewareAfter.