Skip to content

Commit

Permalink
zipkin: remove no-op WithSDKOptions (#2248)
Browse files Browse the repository at this point in the history
This method did not have any effect. had been used back
when exporters were providing utility methods for setting up full
pipelines. These utilities went away in
4883cb1.
  • Loading branch information
andreimatei authored Sep 20, 2021
1 parent 568e755 commit 6183913
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 9 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Removed

- Removed the zipkin.WithSDKOptions function. It already didn't have any effect (#2248).
- Removed the deprecated package `go.opentelemetry.io/otel/oteltest`. (#2234)
- Removed the deprecated package `go.opentelemetry.io/otel/bridge/opencensus/utils`. (#2233)
- Removed deprecated functions, types, and methods from `go.opentelemetry.io/otel/attribute` package.
Expand Down
1 change: 0 additions & 1 deletion example/zipkin/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ func initTracer(url string) func() {
exporter, err := zipkin.New(
url,
zipkin.WithLogger(logger),
zipkin.WithSDKOptions(sdktrace.WithSampler(sdktrace.AlwaysSample())),
)
if err != nil {
log.Fatal(err)
Expand Down
8 changes: 0 additions & 8 deletions exporters/zipkin/zipkin.go
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ var (
type config struct {
client *http.Client
logger *log.Logger
tpOpts []sdktrace.TracerProviderOption
}

// Option defines a function that configures the exporter.
Expand Down Expand Up @@ -77,13 +76,6 @@ func WithClient(client *http.Client) Option {
})
}

// WithSDKOptions configures options passed to the created TracerProvider.
func WithSDKOptions(tpOpts ...sdktrace.TracerProviderOption) Option {
return optionFunc(func(cfg *config) {
cfg.tpOpts = tpOpts
})
}

// New creates a new Zipkin exporter.
func New(collectorURL string, opts ...Option) (*Exporter, error) {
if collectorURL == "" {
Expand Down

0 comments on commit 6183913

Please sign in to comment.