zipkin: remove no-op WithSDKOptions #2248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method did not have any effect. had been used back when exporters were providing utility methods for setting up full pipelines. These utilities went away in 4883cb1.
andreimatei
requested review from
Aneurysm9,
dashpole,
evantorrie,
jmacd,
MadVikingGod,
MrAlias,
paivagustavo,
pellared and
XSAM
as code owners
|
|
pellared
approved these changes
Sep 19, 2021
Codecov Report
@@ Coverage Diff @@
## main #2248 +/- ##
=====================================
Coverage 72.4% 72.5%
=====================================
Files 168 168
Lines 11768 11764 -4
=====================================
+ Hits 8530 8532 +2
+ Misses 3003 2997 -6
Partials 235 235
|
pellared
added
the
blocked:CLA
Done |
pellared
removed
the
blocked:CLA
MrAlias
approved these changes
Sep 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method did not have any effect. had been used back
when exporters were providing utility methods for setting up full
pipelines. These utilities went away in
4883cb1.