Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zipkin: remove no-op WithSDKOptions #2248

Merged
merged 1 commit into from
Sep 20, 2021
Merged

zipkin: remove no-op WithSDKOptions #2248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

### Removed

- Removed the zipkin.WithSDKOptions function. It already didn't have any effect (#2248).
- Removed the deprecated package `go.opentelemetry.io/otel/oteltest`. (#2234)
- Removed the deprecated package `go.opentelemetry.io/otel/bridge/opencensus/utils`. (#2233)
- Removed deprecated functions, types, and methods from `go.opentelemetry.io/otel/attribute` package.
Expand Down
1 change: 0 additions & 1 deletion example/zipkin/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ func initTracer(url string) func() {
exporter, err := zipkin.New(
url,
zipkin.WithLogger(logger),
zipkin.WithSDKOptions(sdktrace.WithSampler(sdktrace.AlwaysSample())),
)
if err != nil {
log.Fatal(err)
Expand Down
8 changes: 0 additions & 8 deletions exporters/zipkin/zipkin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ var (
type config struct {
client *http.Client
logger *log.Logger
tpOpts []sdktrace.TracerProviderOption
}

// Option defines a function that configures the exporter.
Expand Down Expand Up @@ -77,13 +76,6 @@ func WithClient(client *http.Client) Option {
})
}

// WithSDKOptions configures options passed to the created TracerProvider.
func WithSDKOptions(tpOpts ...sdktrace.TracerProviderOption) Option {
return optionFunc(func(cfg *config) {
cfg.tpOpts = tpOpts
})
}

// New creates a new Zipkin exporter.
func New(collectorURL string, opts ...Option) (*Exporter, error) {
if collectorURL == "" {
Expand Down