Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move validation of span limits to its own function. #1705

Closed
MrAlias opened this issue Mar 17, 2021 · 1 comment
Closed

Move validation of span limits to its own function. #1705

MrAlias opened this issue Mar 17, 2021 · 1 comment
Milestone
untracked

Comments

@MrAlias
Copy link
Contributor

MrAlias commented Mar 17, 2021

opentelemetry-go/sdk/trace/provider.go

Lines 183 to 197 in 345f264

if cfg.SpanLimits.EventCountLimit > 0 {
c.SpanLimits.EventCountLimit = cfg.SpanLimits.EventCountLimit
}
if cfg.SpanLimits.AttributeCountLimit > 0 {
c.SpanLimits.AttributeCountLimit = cfg.SpanLimits.AttributeCountLimit
}
if cfg.SpanLimits.LinkCountLimit > 0 {
c.SpanLimits.LinkCountLimit = cfg.SpanLimits.LinkCountLimit
}
if cfg.SpanLimits.AttributePerEventCountLimit > 0 {
c.SpanLimits.AttributePerEventCountLimit = cfg.SpanLimits.AttributePerEventCountLimit
}
if cfg.SpanLimits.AttributePerLinkCountLimit > 0 {
c.SpanLimits.AttributePerLinkCountLimit = cfg.SpanLimits.AttributePerLinkCountLimit
}

Originally posted by @MrAlias in #1693 (comment)
@MrAlias MrAlias mentioned this issue Mar 17, 2021
Merged
ijsong added a commit to ijsong/opentelemetry-go that referenced this issue Mar 18, 2021
@ijsong
sdk/trace: removing ApplyConfig and Config
de816d9 
This patch removes `ApplyConfig` method and `Config` struct from
`go.opentelemetry.io/otel/sdk/trace` package.  To ensure valid config
for TracerProvider, it adds `ensureValidTracerProviderConfig` private
function.
Jaeger and Zipkin have been used the `Config` directly across package
boundaries. Since `Config` is removed, they can't use it. This change,
thus, replcae `WithSDK` with `WithSDKOptions`.

Resolves open-telemetry#1636, open-telemetry#1705.
ijsong added a commit to ijsong/opentelemetry-go that referenced this issue Mar 18, 2021
@ijsong
sdk/trace: removing ApplyConfig and Config
50af6b7 
This patch removes `ApplyConfig` method and `Config` struct from
`go.opentelemetry.io/otel/sdk/trace` package.  To ensure valid config
for TracerProvider, it adds `ensureValidTracerProviderConfig` private
function.
Jaeger and Zipkin have been used the `Config` directly across package
boundaries. Since `Config` is removed, they can't use it. This change,
thus, replaces `WithSDK` with `WithSDKOptions`.

Resolves open-telemetry#1636, open-telemetry#1705.
ijsong added a commit to ijsong/opentelemetry-go that referenced this issue Mar 18, 2021
@ijsong
sdk/trace: removing ApplyConfig and Config
57fd05a 
This patch removes `ApplyConfig` method and `Config` struct from
`go.opentelemetry.io/otel/sdk/trace` package.  To ensure valid config
for TracerProvider, it adds `ensureValidTracerProviderConfig` private
function.
Jaeger and Zipkin have been used the `Config` directly across package
boundaries. Since `Config` is removed, they can't use it. This change,
thus, replaces `WithSDK` with `WithSDKOptions`.

Resolves open-telemetry#1636, open-telemetry#1705.
MrAlias pushed a commit that referenced this issue Mar 18, 2021
@ijsong
sdk/trace: removing ApplyConfig and Config (#1693)
4beb704 
This patch removes `ApplyConfig` method and `Config` struct from
`go.opentelemetry.io/otel/sdk/trace` package.  To ensure valid config
for TracerProvider, it adds `ensureValidTracerProviderConfig` private
function.
Jaeger and Zipkin have been used the `Config` directly across package
boundaries. Since `Config` is removed, they can't use it. This change,
thus, replaces `WithSDK` with `WithSDKOptions`.

Resolves #1636, #1705.
@MrAlias
Copy link
Contributor Author

MrAlias commented Mar 18, 2021

resolved in #1693

@MrAlias MrAlias closed this as completed Mar 18, 2021
@pellared pellared added this to the untracked milestone Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
untracked
Development

No branches or pull requests
2 participants
@pellared @MrAlias